Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: build/android/gyp/jar.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/get_device_configuration.py ('k') | build/android/gyp/jar_toc.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import fnmatch 7 import fnmatch
8 import optparse 8 import optparse
9 import os 9 import os
10 import sys 10 import sys
11 11
12 # pylint: disable=F0401
12 from util import build_utils 13 from util import build_utils
13 from util import md5_check 14 from util import md5_check
15 # pylint: enable=F0401
14 16
15 17
16 def DoJar(options): 18 def DoJar(options):
17 class_files = build_utils.FindInDirectory(options.classes_dir, '*.class') 19 class_files = build_utils.FindInDirectory(options.classes_dir, '*.class')
18 for exclude in build_utils.ParseGypList(options.excluded_classes): 20 for exclude in build_utils.ParseGypList(options.excluded_classes):
19 class_files = filter( 21 class_files = filter(
20 lambda f: not fnmatch.fnmatch(f, exclude), class_files) 22 lambda f: not fnmatch.fnmatch(f, exclude), class_files)
21 23
22 jar_path = os.path.abspath(options.jar_path) 24 jar_path = os.path.abspath(options.jar_path)
23 25
24 # The paths of the files in the jar will be the same as they are passed in to 26 # The paths of the files in the jar will be the same as they are passed in to
25 # the command. Because of this, the command should be run in 27 # the command. Because of this, the command should be run in
26 # options.classes_dir so the .class file paths in the jar are correct. 28 # options.classes_dir so the .class file paths in the jar are correct.
27 jar_cwd = options.classes_dir 29 jar_cwd = options.classes_dir
28 class_files_rel = [os.path.relpath(f, jar_cwd) for f in class_files] 30 class_files_rel = [os.path.relpath(f, jar_cwd) for f in class_files]
29 jar_cmd = ['jar', 'cf0', jar_path] + class_files_rel 31 jar_cmd = ['jar', 'cf0', jar_path] + class_files_rel
30 32
31 record_path = '%s.md5.stamp' % options.jar_path 33 record_path = '%s.md5.stamp' % options.jar_path
32 md5_check.CallAndRecordIfStale( 34 md5_check.CallAndRecordIfStale(
33 lambda: build_utils.CheckOutput(jar_cmd, cwd=jar_cwd), 35 lambda: build_utils.CheckOutput(jar_cmd, cwd=jar_cwd),
34 record_path=record_path, 36 record_path=record_path,
35 input_paths=class_files, 37 input_paths=class_files,
36 input_strings=jar_cmd) 38 input_strings=jar_cmd)
37 39
38 build_utils.Touch(options.jar_path) 40 build_utils.Touch(options.jar_path)
39 41
40 42
41 def main(argv): 43 def main():
42 parser = optparse.OptionParser() 44 parser = optparse.OptionParser()
43 parser.add_option('--classes-dir', help='Directory containing .class files.') 45 parser.add_option('--classes-dir', help='Directory containing .class files.')
44 parser.add_option('--jar-path', help='Jar output path.') 46 parser.add_option('--jar-path', help='Jar output path.')
45 parser.add_option('--excluded-classes', 47 parser.add_option('--excluded-classes',
46 help='List of .class file patterns to exclude from the jar.') 48 help='List of .class file patterns to exclude from the jar.')
47 parser.add_option('--stamp', help='Path to touch on success.') 49 parser.add_option('--stamp', help='Path to touch on success.')
48 50
49 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. 51 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
50 parser.add_option('--ignore', help='Ignored.') 52 parser.add_option('--ignore', help='Ignored.')
51 53
52 options, _ = parser.parse_args() 54 options, _ = parser.parse_args()
53 55
54 DoJar(options) 56 DoJar(options)
55 57
56 if options.stamp: 58 if options.stamp:
57 build_utils.Touch(options.stamp) 59 build_utils.Touch(options.stamp)
58 60
59 61
60 if __name__ == '__main__': 62 if __name__ == '__main__':
61 sys.exit(main(sys.argv)) 63 sys.exit(main())
62 64
OLDNEW
« no previous file with comments | « build/android/gyp/get_device_configuration.py ('k') | build/android/gyp/jar_toc.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698