build/android/pylib/perf/surface_stats_collector.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/perf/surface_stats_collector.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/perf/surface_stats_collector.py

diff --git a/build/android/pylib/perf/surface_stats_collector.py b/build/android/pylib/perf/surface_stats_collector.py

index 9d92b4376ec72d766d4569e5b5ca4be31f01a40e..c54efa9cefb0377043f413392643f6fcb79db752 100644

--- a/build/android/pylib/perf/surface_stats_collector.py

+++ b/build/android/pylib/perf/surface_stats_collector.py

@@ -71,7 +71,8 @@ class SurfaceStatsCollector(object):

def GetResults(self):

return self._results or self._GetEmptyResults()

- def _GetEmptyResults(self):

+ @staticmethod

+ def _GetEmptyResults():

return [

SurfaceStatsCollector.Result('refresh_period', None, 'seconds'),

SurfaceStatsCollector.Result('jank_count', None, 'janks'),

@@ -102,7 +103,7 @@ class SurfaceStatsCollector(object):

frame_count = len(frame_lengths) + 1

if len(frame_lengths) == 0:

raise Exception('No valid frames lengths found.')

- length_changes, normalized_changes = \

+ _length_changes, normalized_changes = \

SurfaceStatsCollector._GetNormalizedDeltas(

frame_lengths, refresh_period)

jankiness = [max(0, round(change)) for change in normalized_changes]