build/android/pylib/flag_changer.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/flag_changer.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/flag_changer.py

diff --git a/build/android/pylib/flag_changer.py b/build/android/pylib/flag_changer.py

index 898037f3dcbadb25f2fe2faa4aa127c3476294a8..d20da36b4e688f3391b182f09b6b46c782dd7719 100644

--- a/build/android/pylib/flag_changer.py

+++ b/build/android/pylib/flag_changer.py

@@ -2,9 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-import constants

import logging

-import traceback

class FlagChanger(object):

@@ -113,7 +111,8 @@ class FlagChanger(object):

assert not self._adb.FileExistsOnDevice(self._cmdline_file), (

'Failed to remove the command line file at %s' % self._cmdline_file)

- def _TokenizeFlags(self, line):

+ @staticmethod

+ def _TokenizeFlags(line):

"""Changes the string containing the command line into a list of flags.

Follows similar logic to CommandLine.java::tokenizeQuotedArguments:

« no previous file with comments | « build/android/pylib/device/adb_wrapper_test.py ('k') | build/android/pylib/forwarder.py » ('j') | no next file with comments »