Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3447)

Unified Diff: build/android/pylib/utils/findbugs.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/utils/findbugs.py
diff --git a/build/android/pylib/utils/findbugs.py b/build/android/pylib/utils/findbugs.py
index 8dde7f6fb1ea7545d3b5e2c541e54841cea5df17..44731113cf9ff12fce34cdbff1d30a3e0abad679 100644
--- a/build/android/pylib/utils/findbugs.py
+++ b/build/android/pylib/utils/findbugs.py
@@ -62,7 +62,7 @@ def _DiffKnownWarnings(current_warnings_set, known_bugs_file):
def _Rebaseline(current_warnings_set, known_bugs_file):
with file(known_bugs_file, 'w') as known_bugs:
for warning in sorted(current_warnings_set):
- print >>known_bugs, warning
+ print >> known_bugs, warning
return 0
@@ -132,7 +132,7 @@ def _Run(exclude, known_bugs, classes_to_analyze, auxiliary_classes,
proc = subprocess.Popen(shlex.split(cmd),
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
- out, err = proc.communicate()
+ out, _err = proc.communicate()
current_warnings_set = set(_StripLineNumbers(filter(None, out.splitlines())))
if rebaseline:
@@ -220,7 +220,7 @@ def GetCommonParser():
return parser
-def main(argv):
+def main():
parser = GetCommonParser()
options, _ = parser.parse_args()
@@ -228,4 +228,4 @@ def main(argv):
if __name__ == '__main__':
- sys.exit(main(sys.argv))
+ sys.exit(main())
« no previous file with comments | « build/android/pylib/utils/emulator.py ('k') | build/android/pylib/utils/flakiness_dashboard_results_uploader.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698