build/android/pylib/utils/xvfb.py - Issue 132463007: Enable presubmit pylint in build/android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/utils/xvfb.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 # pylint: disable=W0702

	6

5 import os	7 import os

6 import signal	8 import signal

7 import subprocess	9 import subprocess

8 import sys	10 import sys

9 import time	11 import time

10	12

11	13

12 def _IsLinux():	14 def _IsLinux():

13 """Return True if on Linux; else False."""	15 """Return True if on Linux; else False."""

14 return sys.platform.startswith('linux')	16 return sys.platform.startswith('linux')

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47	49

48 def Stop(self):	50 def Stop(self):

49 """Stop Xvfb if needed. Linux only."""	51 """Stop Xvfb if needed. Linux only."""

50 if self._pid:	52 if self._pid:

51 try:	53 try:

52 os.kill(self._pid, signal.SIGKILL)	54 os.kill(self._pid, signal.SIGKILL)

53 except:	55 except:

54 pass	56 pass

55 del os.environ['DISPLAY']	57 del os.environ['DISPLAY']

56 self._pid = 0	58 self._pid = 0

OLD	NEW