Rename LayoutStyle to papayawhip

Rename LayoutStyle to ComputedStyle

As discussed[1] on blink-dev.

layoutStyle() accessors are renamed to computedStyle(), former computedStyle()
accessors renamed to ensureComputedStyle().

[1] https://groups.google.com/a/chromium.org/d/topic/blink-dev/0x7LO7FUh4c/discussion

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192793

[dstockwell, 2015-03-25 10:26:19]

dstockwell@chromium.org changed reviewers:
+ esprehn@chromium.org, leviw@chromium.org

[dstockwell, 2015-03-25 10:26:23]

This is basically done, but I've run into a conflict. There's already
computedStyle() accessors on Node/Element which overlap renaming the
layoutStyle() accessors on Node.

Some options,
1. Keep Node::layoutStyle(), layoutStyleRef(), mutableLayoutStyle() and
parentLayoutStyle(). These will continue to refer to the ComputedStyle in
LayoutObject::m_style. This seems reasonably sane.
2. Rename the above to something like Node::layoutComputedStyle() etc.
3. Something else?

[dstockwell, 2015-03-25 22:21:18]

PTAL, I've gone with option 1 for now.

[leviw_travelin_and_unemployed, 2015-03-25 22:49:40]

On 2015/03/25 at 10:26:23, dstockwell wrote:
> This is basically done, but I've run into a conflict. There's already
computedStyle() accessors on Node/Element which overlap renaming the
layoutStyle() accessors on Node.
> 
> Some options,
> 1. Keep Node::layoutStyle(), layoutStyleRef(), mutableLayoutStyle() and
parentLayoutStyle(). These will continue to refer to the ComputedStyle in
LayoutObject::m_style. This seems reasonably sane.
> 2. Rename the above to something like Node::layoutComputedStyle() etc.
> 3. Something else?

I lean towards #2 a bit, since with this change "layoutStyle" doesn't really
make sense. Perhaps we could give the current computedStyle a new name?

[esprehn, 2015-03-25 23:27:03]

I'd prefer we rename the methods on Node, layoutStyle doesn't make sense. I'm
not sure what's better though.

[dstockwell, 2015-03-30 22:22:41]

PTAL. Node::layoutStyle and friends are now renamed as
Node::layoutObjectComputedStyle.

Julien proposed moving this to a new style/ directory. But I'll do that in a
separate patch.

[esprehn, 2015-03-30 22:49:33]

On 2015/03/30 at 22:22:41, dstockwell wrote:
> PTAL. Node::layoutStyle and friends are now renamed as
Node::layoutObjectComputedStyle.
> 
> Julien proposed moving this to a new style/ directory. But I'll do that in a
separate patch.

That honestly seems unnecessarily verbose, can we just call this computedStyle()
and rename the existing getter?

Seeing layoutObjectComputedStyle() everywhere just makes it harder to read the
code that wants to query style.

[dstockwell, 2015-03-30 22:56:18]

On 2015/03/30 at 22:49:33, esprehn wrote:
> On 2015/03/30 at 22:22:41, dstockwell wrote:
> > PTAL. Node::layoutStyle and friends are now renamed as
Node::layoutObjectComputedStyle.
> > 
> > Julien proposed moving this to a new style/ directory. But I'll do that in a
separate patch.
> 
> That honestly seems unnecessarily verbose, can we just call this
computedStyle() and rename the existing getter?
> 
> Seeing layoutObjectComputedStyle() everywhere just makes it harder to read the
code that wants to query style.

Sure, I could rename the existing computedStyle(), but what would we call it?

[shans, 2015-03-30 22:58:03]

On 2015/03/30 22:56:18, dstockwell wrote:
> On 2015/03/30 at 22:49:33, esprehn wrote:
> > On 2015/03/30 at 22:22:41, dstockwell wrote:
> > > PTAL. Node::layoutStyle and friends are now renamed as
> Node::layoutObjectComputedStyle.
> > > 
> > > Julien proposed moving this to a new style/ directory. But I'll do that in
a
> separate patch.
> > 
> > That honestly seems unnecessarily verbose, can we just call this
> computedStyle() and rename the existing getter?
> > 
> > Seeing layoutObjectComputedStyle() everywhere just makes it harder to read
the
> code that wants to query style.
> 
> Sure, I could rename the existing computedStyle(), but what would we call it?

papayaWhip?

[dstockwell, 2015-03-31 00:38:10]

OK. New proposal. Rename the existing computedStyle to ensureComputedStyle. The
only case where it returns null is when we're not in an active document, but
that's a FIXME.

[leviw_travelin_and_unemployed, 2015-03-31 00:45:01]

On 2015/03/31 at 00:38:10, dstockwell wrote:
> OK. New proposal. Rename the existing computedStyle to ensureComputedStyle.
The only case where it returns null is when we're not in an active document, but
that's a FIXME.

That's got my vote completely. computedStyle() feels like the right accessor for
'LayoutStyle'

[dstockwell, 2015-03-31 01:19:36]

PTAL, now patch is updated to use computedStyle() and ensureComputedStyle().

[esprehn, 2015-03-31 01:40:36]

On 2015/03/31 at 01:19:36, dstockwell wrote:
> PTAL, now patch is updated to use computedStyle() and ensureComputedStyle().

rs lgtm, that sounds great!

[dstockwell, 2015-03-31 02:14:41]

dstockwell@chromium.org changed reviewers:
+ dglazkov@chromium.org, tkent@chromium.org
- leviw@chromium.org

[dstockwell, 2015-03-31 02:14:44]

+dglazkov or tkent for uber-stamping.

[tkent, 2015-03-31 02:23:30]

rs lgtm

[dstockwell, 2015-03-31 02:27:23]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2015-03-31 02:27:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1033943002/60001

[dglazkov, 2015-03-31 02:32:41]

Wow much pretty wow wow happy yay

[commit-bot: I haz the power, 2015-03-31 03:40:38]

Committed patchset #7 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192793

[leviw_travelin_and_unemployed, 2015-03-31 03:41:15]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-03-31 03:41:18]

LateGTM because this is so full of win :D