Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 7461141: Rename BASE_API to BASE_EXPORT. (Closed)

Created:
9 years, 4 months ago by darin (slow to review)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Rename BASE_API to BASE_EXPORT. R=rvargas Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95618

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+973 lines, -971 lines) Patch
M base/at_exit.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/atomicops_internals_x86_gcc.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/base.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M base/base64.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
D base/base_api.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
A + base/base_export.h View 1 chunk +7 lines, -7 lines 0 comments Download
M base/callback_internal.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/command_line.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/cpu.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/alias.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/debugger.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M base/debug/profiler.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M base/debug/stack_trace.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/trace_event.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M base/debug/trace_event_win.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M base/environment.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/event_recorder.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_descriptor_shuffle.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M base/file_path.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_util.h View 1 16 chunks +103 lines, -101 lines 0 comments Download
M base/file_util_deprecated.h View 1 2 chunks +13 lines, -12 lines 0 comments Download
M base/file_util_proxy.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_version_info.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M base/file_version_info_win.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M base/files/file_path_watcher.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/global_descriptors_posix.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_reader.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/json/json_writer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/json/string_escape.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M base/lazy_instance.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/linux_util.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M base/logging.h View 1 12 chunks +26 lines, -26 lines 0 comments Download
M base/logging_win.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/mac/foundation_util.h View 1 8 chunks +31 lines, -30 lines 0 comments Download
M base/mac/mac_util.h View 1 5 chunks +28 lines, -28 lines 0 comments Download
M base/mac/objc_property_releaser.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/mac/os_crash_dumps.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/mac/scoped_nsautorelease_pool.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/mac/scoped_nsexception_enabler.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M base/mach_ipc_mac.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M base/md5.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M base/memory/memory_debug.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/ref_counted.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/memory/ref_counted_memory.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M base/memory/weak_ptr.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M base/message_loop.h View 1 7 chunks +7 lines, -7 lines 0 comments Download
M base/message_loop_proxy.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/message_loop_proxy_impl.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M base/message_pump.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/message_pump_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump_libevent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump_win.h View 1 5 chunks +6 lines, -6 lines 0 comments Download
M base/message_pump_x.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/metrics/field_trial.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/metrics/histogram.h View 1 7 chunks +7 lines, -7 lines 0 comments Download
M base/metrics/stats_counters.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M base/metrics/stats_table.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/mime_util.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M base/native_library.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M base/nix/xdg_util.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M base/path_service.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/pickle.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/platform_file.h View 1 4 chunks +18 lines, -17 lines 0 comments Download
M base/process.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/process_util.h View 1 16 chunks +69 lines, -65 lines 0 comments Download
M base/rand_util.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M base/rand_util_c.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/resource_util.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M base/safe_strerror_posix.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/scoped_native_library.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/scoped_temp_dir.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/sha1.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M base/shared_memory.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/string16.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M base/string_number_conversions.h View 1 5 chunks +43 lines, -40 lines 0 comments Download
M base/string_piece.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/string_split.h View 1 3 chunks +27 lines, -27 lines 0 comments Download
M base/string_util.h View 1 11 chunks +145 lines, -137 lines 0 comments Download
M base/stringprintf.h View 1 1 chunk +14 lines, -13 lines 0 comments Download
M base/sync_socket.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/synchronization/cancellation_flag.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/synchronization/condition_variable.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/synchronization/lock.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/synchronization/lock_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/synchronization/waitable_event.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/synchronization/waitable_event_watcher.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/sys_info.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/sys_string_conversions.h View 1 4 chunks +21 lines, -21 lines 0 comments Download
M base/system_monitor/system_monitor.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/task.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M base/task_queue.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/third_party/nspr/prtime.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/non_thread_safe_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/platform_thread.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/threading/simple_thread.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M base/threading/thread.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/thread_checker_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/thread_collision_warner.h View 1 5 chunks +7 lines, -7 lines 0 comments Download
M base/threading/thread_local.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/thread_local_storage.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/threading/thread_restrictions.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M base/threading/watchdog.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/worker_pool.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/time.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M base/timer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/tracked.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M base/tracked.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/tracked_objects.h View 1 10 chunks +10 lines, -10 lines 0 comments Download
M base/utf_offset_string_conversions.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
M base/utf_string_conversion_utils.h View 1 3 chunks +15 lines, -14 lines 0 comments Download
M base/utf_string_conversions.h View 1 3 chunks +20 lines, -18 lines 0 comments Download
M base/value_conversions.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/values.h View 1 8 chunks +8 lines, -8 lines 0 comments Download
M base/version.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/vlog.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M base/win/event_trace_controller.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/win/event_trace_provider.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/i18n.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/win/iat_patch_function.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/object_watcher.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/win/registry.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M base/win/scoped_bstr.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/scoped_variant.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/win_util.h View 1 3 chunks +16 lines, -15 lines 0 comments Download
M base/win/windows_version.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/win/wrapped_window_proc.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
9 years, 4 months ago (2011-08-04 22:56:07 UTC) #1
rvargas (doing something else)
9 years, 4 months ago (2011-08-04 23:46:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698