Standardize usage of virtual/override/final in mojo/

Standardize usage of virtual/override/final in mojo/

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=mpcomplete@chromium.org

Committed: https://crrev.com/3fc12db4bdf0829f206dafbb23d411ff502d7de6
Cr-Commit-Position: refs/heads/master@{#300470}

[dcheng, 2014-10-21 10:41:30]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-10-21 10:45:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668663006/1

[commit-bot: I haz the power, 2014-10-21 12:16:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-21 13:09:48]

Patchset 1 (id:??) landed as
https://crrev.com/3fc12db4bdf0829f206dafbb23d411ff502d7de6
Cr-Commit-Position: refs/heads/master@{#300470}

[viettrungluu, 2014-10-21 14:27:12]

On 2014/10/21 13:09:48, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3fc12db4bdf0829f206dafbb23d411ff502d7de6
> Cr-Commit-Position: refs/heads/master@{#300470}

Why does this not convert various things in tests (e.g., we still have |virtual
SetUp() override| and also |virtual ~CoreTestBase();|?

[dcheng, 2014-10-21 15:40:24]

On 2014/10/21 14:27:12, viettrungluu wrote:
> On 2014/10/21 13:09:48, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/3fc12db4bdf0829f206dafbb23d411ff502d7de6
> > Cr-Commit-Position: refs/heads/master@{#300470}
> 
> Why does this not convert various things in tests (e.g., we still have
|virtual
> SetUp() override| and also |virtual ~CoreTestBase();|?

I don't know. This runs on a per platform basis and I've only had time to run
the tools across Mac. Windows specific stuff poses its own challenges as well.
My goal is to automate as much as possible with clang, and use more primitive
strategies (e.g. cpplint) to clean up the rest, since the clang changes should
largely be rubber stampable.

[viettrungluu, 2014-10-21 16:39:20]

On 2014/10/21 15:40:24, dcheng wrote:
> On 2014/10/21 14:27:12, viettrungluu wrote:
> > On 2014/10/21 13:09:48, I haz the power (commit-bot) wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/3fc12db4bdf0829f206dafbb23d411ff502d7de6
> > > Cr-Commit-Position: refs/heads/master@{#300470}
> > 
> > Why does this not convert various things in tests (e.g., we still have
> |virtual
> > SetUp() override| and also |virtual ~CoreTestBase();|?
> 
> I don't know. This runs on a per platform basis and I've only had time to run
> the tools across Mac. Windows specific stuff poses its own challenges as well.

Running the tools on Mac misses a lot of stuff in mojo/. Do you have
instructions on how to run it on Linux?

> My goal is to automate as much as possible with clang, and use more primitive
> strategies (e.g. cpplint) to clean up the rest, since the clang changes should
> largely be rubber stampable.

[dcheng, 2014-10-21 16:44:52]

On 2014/10/21 at 16:39:20, viettrungluu wrote:
> On 2014/10/21 15:40:24, dcheng wrote:
> > On 2014/10/21 14:27:12, viettrungluu wrote:
> > > On 2014/10/21 13:09:48, I haz the power (commit-bot) wrote:
> > > > Patchset 1 (id:??) landed as
> > > > https://crrev.com/3fc12db4bdf0829f206dafbb23d411ff502d7de6
> > > > Cr-Commit-Position: refs/heads/master@{#300470}
> > > 
> > > Why does this not convert various things in tests (e.g., we still have
> > |virtual
> > > SetUp() override| and also |virtual ~CoreTestBase();|?
> > 
> > I don't know. This runs on a per platform basis and I've only had time to
run
> > the tools across Mac. Windows specific stuff poses its own challenges as
well.
> 
> Running the tools on Mac misses a lot of stuff in mojo/. Do you have
instructions on how to run it on Linux?
> 
> > My goal is to automate as much as possible with clang, and use more
primitive
> > strategies (e.g. cpplint) to clean up the rest, since the clang changes
should
> > largely be rubber stampable.

I'll be running it the tooling process over Linux/CrOS/Android later today. If
you want to do it yourself, you can use the patch at
https://codereview.chromium.org/598073004 to use the same workflow.

Prerequisites:
You must build locally, without goma.
You must be using a clang roll past 218xxx.

In a loop, until all compilation steps succeed:
# I like the tail so I can see if we're blocked on something the rewriter can't
handle
ninja -C out/Debug -k 1000 > fixits; tail -n fixits
python tools/clang/scripts/apply-fixits.py < fixits

Unfortunately, the way we emit fixits for destructors means that you'll need
multiple passes. The first pass suggests adding override, and then the second
compilation pass will fail, suggesting that virtual be removed since it is
redundant with override. Fixing this isn't a high priority for me though.

[Matt Perry, 2014-10-21 19:15:08]

lgtm