mojo/services/test_service/test_request_tracker_client_impl.h - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/test_service/test_request_tracker_client_impl.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/test_service/test_request_tracker_application.h ('k') | mojo/services/test_service/test_request_tracker_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/test_service/test_request_tracker_client_impl.h

diff --git a/mojo/services/test_service/test_request_tracker_client_impl.h b/mojo/services/test_service/test_request_tracker_client_impl.h

index 91340cb8f429a01cea4bbb66bba6d84194ff9ff6..16f5cba3bafe7522fa444223dba268dd18758ee7 100644

--- a/mojo/services/test_service/test_request_tracker_client_impl.h

+++ b/mojo/services/test_service/test_request_tracker_client_impl.h

@@ -17,13 +17,13 @@ class TestRequestTrackerClientImpl : public TestRequestTrackerClient {

TestRequestTrackerPtr tracker,

const std::string& service_name,

const mojo::Callback<void()>& tracking_connected_callback);

- virtual ~TestRequestTrackerClientImpl();

+ ~TestRequestTrackerClientImpl() override;

// Call whenever an event happens that you want to be recorded.

void RecordNewRequest();

// TestRequestTrackerClient impl.

- virtual void SetIdAndReturnName(

+ void SetIdAndReturnName(

uint64_t id,

const mojo::Callback<void(mojo::String)>& callback) override;