mojo/public/cpp/application/service_provider_impl.h - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/application/service_provider_impl.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/application/lib/weak_service_provider.h ('k') | mojo/public/cpp/application/tests/service_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/application/service_provider_impl.h

diff --git a/mojo/public/cpp/application/service_provider_impl.h b/mojo/public/cpp/application/service_provider_impl.h

index 92f8f3572febd4c9866d4c3c7c1ef706da4588c5..45ad7b8456ea8e14c1df5a1fc235ecde2cebea53 100644

--- a/mojo/public/cpp/application/service_provider_impl.h

+++ b/mojo/public/cpp/application/service_provider_impl.h

@@ -18,7 +18,7 @@ class ServiceConnectorBase;

class ServiceProviderImpl : public InterfaceImpl<ServiceProvider> {

public:

ServiceProviderImpl();

- virtual ~ServiceProviderImpl();

+ ~ServiceProviderImpl() override;

template <typename Interface>

void AddService(InterfaceFactory<Interface>* factory) {

@@ -42,11 +42,11 @@ class ServiceProviderImpl : public InterfaceImpl<ServiceProvider> {

friend class internal::WeakServiceProvider;

// Overridden from ServiceProvider:

- virtual void ConnectToService(const String& service_name,

- ScopedMessagePipeHandle client_handle) override;

+ void ConnectToService(const String& service_name,

+ ScopedMessagePipeHandle client_handle) override;

// Overridden from InterfaceImpl:

- virtual void OnConnectionError() override;

+ void OnConnectionError() override;

void AddServiceConnector(internal::ServiceConnectorBase* service_connector);

void RemoveServiceConnector(