Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: mojo/edk/system/local_data_pipe.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/dispatcher_unittest.cc ('k') | mojo/edk/system/local_message_pipe_endpoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/local_data_pipe.h
diff --git a/mojo/edk/system/local_data_pipe.h b/mojo/edk/system/local_data_pipe.h
index 8d3b75b7e31fdf07b064ff4afd2fcf12863097f4..8a46c52ec8b1dc9f053ecbdad5f0969af2d0179f 100644
--- a/mojo/edk/system/local_data_pipe.h
+++ b/mojo/edk/system/local_data_pipe.h
@@ -27,43 +27,40 @@ class MOJO_SYSTEM_IMPL_EXPORT LocalDataPipe : public DataPipe {
private:
friend class base::RefCountedThreadSafe<LocalDataPipe>;
- virtual ~LocalDataPipe();
+ ~LocalDataPipe() override;
// |DataPipe| implementation:
- virtual void ProducerCloseImplNoLock() override;
- virtual MojoResult ProducerWriteDataImplNoLock(
+ void ProducerCloseImplNoLock() override;
+ MojoResult ProducerWriteDataImplNoLock(
UserPointer<const void> elements,
UserPointer<uint32_t> num_bytes,
uint32_t max_num_bytes_to_write,
uint32_t min_num_bytes_to_write) override;
- virtual MojoResult ProducerBeginWriteDataImplNoLock(
+ MojoResult ProducerBeginWriteDataImplNoLock(
UserPointer<void*> buffer,
UserPointer<uint32_t> buffer_num_bytes,
uint32_t min_num_bytes_to_write) override;
- virtual MojoResult ProducerEndWriteDataImplNoLock(
+ MojoResult ProducerEndWriteDataImplNoLock(
uint32_t num_bytes_written) override;
- virtual HandleSignalsState ProducerGetHandleSignalsStateImplNoLock()
- const override;
- virtual void ConsumerCloseImplNoLock() override;
- virtual MojoResult ConsumerReadDataImplNoLock(
+ HandleSignalsState ProducerGetHandleSignalsStateImplNoLock() const override;
+ void ConsumerCloseImplNoLock() override;
+ MojoResult ConsumerReadDataImplNoLock(
UserPointer<void> elements,
UserPointer<uint32_t> num_bytes,
uint32_t max_num_bytes_to_read,
uint32_t min_num_bytes_to_read) override;
- virtual MojoResult ConsumerDiscardDataImplNoLock(
+ MojoResult ConsumerDiscardDataImplNoLock(
UserPointer<uint32_t> num_bytes,
uint32_t max_num_bytes_to_discard,
uint32_t min_num_bytes_to_discard) override;
- virtual MojoResult ConsumerQueryDataImplNoLock(
+ MojoResult ConsumerQueryDataImplNoLock(
UserPointer<uint32_t> num_bytes) override;
- virtual MojoResult ConsumerBeginReadDataImplNoLock(
+ MojoResult ConsumerBeginReadDataImplNoLock(
UserPointer<const void*> buffer,
UserPointer<uint32_t> buffer_num_bytes,
uint32_t min_num_bytes_to_read) override;
- virtual MojoResult ConsumerEndReadDataImplNoLock(
- uint32_t num_bytes_read) override;
- virtual HandleSignalsState ConsumerGetHandleSignalsStateImplNoLock()
- const override;
+ MojoResult ConsumerEndReadDataImplNoLock(uint32_t num_bytes_read) override;
+ HandleSignalsState ConsumerGetHandleSignalsStateImplNoLock() const override;
void EnsureBufferNoLock();
void DestroyBufferNoLock();
« no previous file with comments | « mojo/edk/system/dispatcher_unittest.cc ('k') | mojo/edk/system/local_message_pipe_endpoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698