Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: mojo/services/surfaces/surfaces_impl.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SERVICES_SURFACES_SURFACES_IMPL_H_ 5 #ifndef MOJO_SERVICES_SURFACES_SURFACES_IMPL_H_
6 #define MOJO_SERVICES_SURFACES_SURFACES_IMPL_H_ 6 #define MOJO_SERVICES_SURFACES_SURFACES_IMPL_H_
7 7
8 #include "cc/surfaces/display_client.h" 8 #include "cc/surfaces/display_client.h"
9 #include "cc/surfaces/surface_factory.h" 9 #include "cc/surfaces/surface_factory.h"
10 #include "cc/surfaces/surface_factory_client.h" 10 #include "cc/surfaces/surface_factory_client.h"
(...skipping 16 matching lines...) Expand all
27 public: 27 public:
28 class Client { 28 class Client {
29 public: 29 public:
30 virtual void FrameSubmitted() = 0; 30 virtual void FrameSubmitted() = 0;
31 virtual void SetDisplay(cc::Display*) = 0; 31 virtual void SetDisplay(cc::Display*) = 0;
32 }; 32 };
33 33
34 SurfacesImpl(cc::SurfaceManager* manager, 34 SurfacesImpl(cc::SurfaceManager* manager,
35 uint32_t id_namespace, 35 uint32_t id_namespace,
36 Client* client); 36 Client* client);
37 virtual ~SurfacesImpl(); 37 ~SurfacesImpl() override;
38 38
39 // Surface implementation. 39 // Surface implementation.
40 virtual void CreateSurface(SurfaceIdPtr id, mojo::SizePtr size) override; 40 void CreateSurface(SurfaceIdPtr id, mojo::SizePtr size) override;
41 virtual void SubmitFrame(SurfaceIdPtr id, FramePtr frame) override; 41 void SubmitFrame(SurfaceIdPtr id, FramePtr frame) override;
42 virtual void DestroySurface(SurfaceIdPtr id) override; 42 void DestroySurface(SurfaceIdPtr id) override;
43 virtual void CreateGLES2BoundSurface(CommandBufferPtr gles2_client, 43 void CreateGLES2BoundSurface(CommandBufferPtr gles2_client,
44 SurfaceIdPtr id, 44 SurfaceIdPtr id,
45 mojo::SizePtr size) override; 45 mojo::SizePtr size) override;
46 46
47 // SurfaceFactoryClient implementation. 47 // SurfaceFactoryClient implementation.
48 virtual void ReturnResources( 48 void ReturnResources(const cc::ReturnedResourceArray& resources) override;
49 const cc::ReturnedResourceArray& resources) override;
50 49
51 // DisplayClient implementation. 50 // DisplayClient implementation.
52 virtual void DisplayDamaged() override; 51 void DisplayDamaged() override;
53 virtual void DidSwapBuffers() override; 52 void DidSwapBuffers() override;
54 virtual void DidSwapBuffersComplete() override; 53 void DidSwapBuffersComplete() override;
55 virtual void CommitVSyncParameters(base::TimeTicks timebase, 54 void CommitVSyncParameters(base::TimeTicks timebase,
56 base::TimeDelta interval) override; 55 base::TimeDelta interval) override;
57 virtual void OutputSurfaceLost() override; 56 void OutputSurfaceLost() override;
58 virtual void SetMemoryPolicy(const cc::ManagedMemoryPolicy& policy) override; 57 void SetMemoryPolicy(const cc::ManagedMemoryPolicy& policy) override;
59 58
60 cc::SurfaceFactory* factory() { return &factory_; } 59 cc::SurfaceFactory* factory() { return &factory_; }
61 60
62 private: 61 private:
63 cc::SurfaceManager* manager_; 62 cc::SurfaceManager* manager_;
64 cc::SurfaceFactory factory_; 63 cc::SurfaceFactory factory_;
65 uint32_t id_namespace_; 64 uint32_t id_namespace_;
66 Client* client_; 65 Client* client_;
67 scoped_ptr<cc::Display> display_; 66 scoped_ptr<cc::Display> display_;
68 ScopedMessagePipeHandle command_buffer_handle_; 67 ScopedMessagePipeHandle command_buffer_handle_;
69 68
70 DISALLOW_COPY_AND_ASSIGN(SurfacesImpl); 69 DISALLOW_COPY_AND_ASSIGN(SurfacesImpl);
71 }; 70 };
72 71
73 } // namespace mojo 72 } // namespace mojo
74 73
75 #endif // MOJO_SERVICES_SURFACES_SURFACES_IMPL_H_ 74 #endif // MOJO_SERVICES_SURFACES_SURFACES_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698