mojo/bindings/js/handle.h - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/bindings/js/handle.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/bindings/js/handle.h

diff --git a/mojo/bindings/js/handle.h b/mojo/bindings/js/handle.h

index 4f0d9b5d120d886c2c7ee09887c3f502fa14b1b2..b0f250c61a5f2c99477260cbc50fa493876e929e 100644

--- a/mojo/bindings/js/handle.h

+++ b/mojo/bindings/js/handle.h

@@ -35,7 +35,7 @@ class HandleWrapper : public gin::Wrappable<HandleWrapper> {

protected:

HandleWrapper(MojoHandle handle);

- virtual ~HandleWrapper();

+ ~HandleWrapper() override;

void NotifyCloseObservers();

mojo::ScopedHandle handle_;

« no previous file with comments | « mojo/apps/js/test/js_to_cpp_unittest.cc ('k') | mojo/bindings/js/waiting_callback.h » ('j') | no next file with comments »