Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: mojo/shell/ui_application_loader_android.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/shell/test_child_process.h ('k') | mojo/spy/spy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_ 5 #ifndef MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_
6 #define MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_ 6 #define MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "mojo/application_manager/application_loader.h" 10 #include "mojo/application_manager/application_loader.h"
11 11
12 namespace mojo { 12 namespace mojo {
13 13
14 class ApplicationManager; 14 class ApplicationManager;
15 15
16 namespace shell { 16 namespace shell {
17 class Context; 17 class Context;
18 } 18 }
19 19
20 // ApplicationLoader implementation that creates a background thread and issues 20 // ApplicationLoader implementation that creates a background thread and issues
21 // load 21 // load
22 // requests there. 22 // requests there.
23 class UIApplicationLoader : public ApplicationLoader { 23 class UIApplicationLoader : public ApplicationLoader {
24 public: 24 public:
25 UIApplicationLoader(scoped_ptr<ApplicationLoader> real_loader, 25 UIApplicationLoader(scoped_ptr<ApplicationLoader> real_loader,
26 shell::Context* context); 26 shell::Context* context);
27 virtual ~UIApplicationLoader(); 27 ~UIApplicationLoader() override;
28 28
29 // ApplicationLoader overrides: 29 // ApplicationLoader overrides:
30 virtual void Load(ApplicationManager* manager, 30 void Load(ApplicationManager* manager,
31 const GURL& url, 31 const GURL& url,
32 scoped_refptr<LoadCallbacks> callbacks) override; 32 scoped_refptr<LoadCallbacks> callbacks) override;
33 virtual void OnApplicationError(ApplicationManager* manager, 33 void OnApplicationError(ApplicationManager* manager,
34 const GURL& url) override; 34 const GURL& url) override;
35 35
36 private: 36 private:
37 class UILoader; 37 class UILoader;
38 38
39 // These functions are exected on the background thread. They call through 39 // These functions are exected on the background thread. They call through
40 // to |background_loader_| to do the actual loading. 40 // to |background_loader_| to do the actual loading.
41 // TODO: having this code take a |manager| is fragile (as ApplicationManager 41 // TODO: having this code take a |manager| is fragile (as ApplicationManager
42 // isn't thread safe). 42 // isn't thread safe).
43 void LoadOnUIThread(ApplicationManager* manager, 43 void LoadOnUIThread(ApplicationManager* manager,
44 const GURL& url, 44 const GURL& url,
45 ScopedMessagePipeHandle* shell_handle); 45 ScopedMessagePipeHandle* shell_handle);
46 void OnApplicationErrorOnUIThread(ApplicationManager* manager, 46 void OnApplicationErrorOnUIThread(ApplicationManager* manager,
47 const GURL& url); 47 const GURL& url);
48 void ShutdownOnUIThread(); 48 void ShutdownOnUIThread();
49 49
50 scoped_ptr<ApplicationLoader> loader_; 50 scoped_ptr<ApplicationLoader> loader_;
51 shell::Context* context_; 51 shell::Context* context_;
52 52
53 // Lives on the UI thread. Trivial interface that calls through to |loader_|. 53 // Lives on the UI thread. Trivial interface that calls through to |loader_|.
54 UILoader* ui_loader_; 54 UILoader* ui_loader_;
55 55
56 DISALLOW_COPY_AND_ASSIGN(UIApplicationLoader); 56 DISALLOW_COPY_AND_ASSIGN(UIApplicationLoader);
57 }; 57 };
58 58
59 } // namespace mojo 59 } // namespace mojo
60 60
61 #endif // MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_ 61 #endif // MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_
OLDNEW
« no previous file with comments | « mojo/shell/test_child_process.h ('k') | mojo/spy/spy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698