Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: mojo/shell/external_application_listener_posix.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/external_application_listener_posix.h
diff --git a/mojo/shell/external_application_listener_posix.h b/mojo/shell/external_application_listener_posix.h
index 788a4ff28d7119d11c533bda8b694d5558bcba22..fee212edafb7e68a0e1f41ac117c24db39012e6b 100644
--- a/mojo/shell/external_application_listener_posix.h
+++ b/mojo/shell/external_application_listener_posix.h
@@ -56,26 +56,25 @@ class ExternalApplicationListenerPosix
// Some of this class' internal state needs to be destroyed on io_runner_,
// so the destructor will post a task to that thread to call StopListening()
// and then wait for it to complete.
- virtual ~ExternalApplicationListenerPosix();
+ ~ExternalApplicationListenerPosix() override;
// Begin listening (on io_runner) to a socket at listen_socket_path.
// Incoming registration requests will be forwarded to register_callback.
// Errors are ignored.
- virtual void ListenInBackground(
- const base::FilePath& listen_socket_path,
- const RegisterCallback& register_callback) override;
+ void ListenInBackground(const base::FilePath& listen_socket_path,
+ const RegisterCallback& register_callback) override;
// Begin listening (on io_runner) to a socket at listen_socket_path.
// Incoming registration requests will be forwarded to register_callback.
// Errors are reported via error_callback.
- virtual void ListenInBackgroundWithErrorCallback(
+ void ListenInBackgroundWithErrorCallback(
const base::FilePath& listen_socket_path,
const RegisterCallback& register_callback,
const ErrorCallback& error_callback) override;
// Block the current thread until listening has started on io_runner.
// If listening has already started, returns immediately.
- virtual void WaitForListening() override;
+ void WaitForListening() override;
private:
class RegistrarImpl;
@@ -90,8 +89,8 @@ class ExternalApplicationListenerPosix
void StopListening(base::WaitableEvent* event);
// Implementation of IncomingConnectionListener::Delegate
- virtual void OnListening(int rv) override;
- virtual void OnConnection(net::SocketDescriptor incoming) override;
+ void OnListening(int rv) override;
+ void OnConnection(net::SocketDescriptor incoming) override;
// If listener_ fails to start listening, this method is run on shell_runner_
// to report the error.
« no previous file with comments | « mojo/shell/dynamic_application_loader_unittest.cc ('k') | mojo/shell/external_application_listener_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698