Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: mojo/edk/system/simple_dispatcher.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_ 5 #ifndef MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_
6 #define MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_ 6 #define MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "mojo/edk/system/dispatcher.h" 11 #include "mojo/edk/system/dispatcher.h"
12 #include "mojo/edk/system/system_impl_export.h" 12 #include "mojo/edk/system/system_impl_export.h"
13 #include "mojo/edk/system/waiter_list.h" 13 #include "mojo/edk/system/waiter_list.h"
14 14
15 namespace mojo { 15 namespace mojo {
16 namespace system { 16 namespace system {
17 17
18 // A base class for simple dispatchers. "Simple" means that there's a one-to-one 18 // A base class for simple dispatchers. "Simple" means that there's a one-to-one
19 // correspondence between handles and dispatchers (see the explanatory comment 19 // correspondence between handles and dispatchers (see the explanatory comment
20 // in core.cc). This class implements the standard waiter-signalling mechanism 20 // in core.cc). This class implements the standard waiter-signalling mechanism
21 // in that case. 21 // in that case.
22 class MOJO_SYSTEM_IMPL_EXPORT SimpleDispatcher : public Dispatcher { 22 class MOJO_SYSTEM_IMPL_EXPORT SimpleDispatcher : public Dispatcher {
23 protected: 23 protected:
24 SimpleDispatcher(); 24 SimpleDispatcher();
25 virtual ~SimpleDispatcher(); 25 ~SimpleDispatcher() override;
26 26
27 // To be called by subclasses when the state changes (so 27 // To be called by subclasses when the state changes (so
28 // |GetHandleSignalsStateImplNoLock()| should be checked again). Must be 28 // |GetHandleSignalsStateImplNoLock()| should be checked again). Must be
29 // called under lock. 29 // called under lock.
30 void HandleSignalsStateChangedNoLock(); 30 void HandleSignalsStateChangedNoLock();
31 31
32 // |Dispatcher| protected methods: 32 // |Dispatcher| protected methods:
33 virtual void CancelAllWaitersNoLock() override; 33 void CancelAllWaitersNoLock() override;
34 virtual MojoResult AddWaiterImplNoLock( 34 MojoResult AddWaiterImplNoLock(Waiter* waiter,
35 Waiter* waiter, 35 MojoHandleSignals signals,
36 MojoHandleSignals signals, 36 uint32_t context,
37 uint32_t context, 37 HandleSignalsState* signals_state) override;
38 HandleSignalsState* signals_state) override; 38 void RemoveWaiterImplNoLock(Waiter* waiter,
39 virtual void RemoveWaiterImplNoLock( 39 HandleSignalsState* signals_state) override;
40 Waiter* waiter,
41 HandleSignalsState* signals_state) override;
42 40
43 private: 41 private:
44 // Protected by |lock()|: 42 // Protected by |lock()|:
45 WaiterList waiter_list_; 43 WaiterList waiter_list_;
46 44
47 DISALLOW_COPY_AND_ASSIGN(SimpleDispatcher); 45 DISALLOW_COPY_AND_ASSIGN(SimpleDispatcher);
48 }; 46 };
49 47
50 } // namespace system 48 } // namespace system
51 } // namespace mojo 49 } // namespace mojo
52 50
53 #endif // MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_ 51 #endif // MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_
OLDNEW
« no previous file with comments | « mojo/edk/system/shared_buffer_dispatcher.h ('k') | mojo/edk/system/simple_dispatcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698