mojo/edk/system/channel.h - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/channel.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/channel.h

diff --git a/mojo/edk/system/channel.h b/mojo/edk/system/channel.h

index c09f4c0117270cc37eb3780af8a9f14269dde1c2..fd718e57411892ebc4eaa1a126750f994962b8ad 100644

--- a/mojo/edk/system/channel.h

+++ b/mojo/edk/system/channel.h

@@ -128,13 +128,13 @@ class MOJO_SYSTEM_IMPL_EXPORT Channel

private:

friend class base::RefCountedThreadSafe<Channel>;

- virtual ~Channel();

+ ~Channel() override;

// |RawChannel::Delegate| implementation (only called on the creation thread):

- virtual void OnReadMessage(

+ void OnReadMessage(

const MessageInTransit::View& message_view,

embedder::ScopedPlatformHandleVectorPtr platform_handles) override;

- virtual void OnError(Error error) override;

+ void OnError(Error error) override;

// Helpers for |OnReadMessage| (only called on the creation thread):

void OnReadMessageForDownstream(

« no previous file with comments | « mojo/edk/embedder/simple_platform_support.h ('k') | mojo/edk/system/channel_unittest.cc » ('j') | no next file with comments »