mojo/services/native_viewport/gpu_impl.h - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/native_viewport/gpu_impl.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/services/native_viewport/gpu_impl.h

diff --git a/mojo/services/native_viewport/gpu_impl.h b/mojo/services/native_viewport/gpu_impl.h

index 4aeb53b167e4557532a4d65fe084f295eb8f3a5f..6b996c71520e6ac3d43046e229e7a39de2135c1a 100644

--- a/mojo/services/native_viewport/gpu_impl.h

+++ b/mojo/services/native_viewport/gpu_impl.h

@@ -27,14 +27,14 @@ class GpuImpl : public InterfaceImpl<Gpu> {

GpuImpl(const scoped_refptr<gfx::GLShareGroup>& share_group,

const scoped_refptr<gpu::gles2::MailboxManager> mailbox_manager);

- virtual ~GpuImpl();

+ ~GpuImpl() override;

- virtual void CreateOnscreenGLES2Context(

+ void CreateOnscreenGLES2Context(

uint64_t native_viewport_id,

SizePtr size,

InterfaceRequest<CommandBuffer> command_buffer_request) override;

- virtual void CreateOffscreenGLES2Context(

+ void CreateOffscreenGLES2Context(

InterfaceRequest<CommandBuffer> command_buffer_request) override;

private:

« no previous file with comments | « mojo/services/html_viewer/webthread_impl.cc ('k') | mojo/services/native_viewport/main.cc » ('j') | no next file with comments »