Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Side by Side Diff: mojo/public/cpp/utility/tests/thread_unittest.cc

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/utility/thread.h" 5 #include "mojo/public/cpp/utility/thread.h"
6 6
7 #include "mojo/public/cpp/system/macros.h" 7 #include "mojo/public/cpp/system/macros.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace mojo { 10 namespace mojo {
11 namespace { 11 namespace {
12 12
13 class SetIntThread : public Thread { 13 class SetIntThread : public Thread {
14 public: 14 public:
15 SetIntThread(int* int_to_set, int value) 15 SetIntThread(int* int_to_set, int value)
16 : int_to_set_(int_to_set), 16 : int_to_set_(int_to_set),
17 value_(value) { 17 value_(value) {
18 } 18 }
19 SetIntThread(const Options& options, int* int_to_set, int value) 19 SetIntThread(const Options& options, int* int_to_set, int value)
20 : Thread(options), 20 : Thread(options),
21 int_to_set_(int_to_set), 21 int_to_set_(int_to_set),
22 value_(value) { 22 value_(value) {
23 } 23 }
24 24
25 virtual ~SetIntThread() { 25 ~SetIntThread() override {}
26 }
27 26
28 virtual void Run() override { *int_to_set_ = value_; } 27 void Run() override { *int_to_set_ = value_; }
29 28
30 private: 29 private:
31 int* const int_to_set_; 30 int* const int_to_set_;
32 const int value_; 31 const int value_;
33 32
34 MOJO_DISALLOW_COPY_AND_ASSIGN(SetIntThread); 33 MOJO_DISALLOW_COPY_AND_ASSIGN(SetIntThread);
35 }; 34 };
36 35
37 TEST(ThreadTest, CreateAndJoin) { 36 TEST(ThreadTest, CreateAndJoin) {
38 int value = 0; 37 int value = 0;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 options.set_stack_size(static_cast<size_t>(-1)); 97 options.set_stack_size(static_cast<size_t>(-1));
99 SetIntThread thread(options, &value, 4); 98 SetIntThread thread(options, &value, 4);
100 thread.Start(); 99 thread.Start();
101 thread.Join(); 100 thread.Join();
102 }, ""); 101 }, "");
103 } 102 }
104 #endif // !defined(NDEBUG) 103 #endif // !defined(NDEBUG)
105 104
106 } // namespace 105 } // namespace
107 } // namespace mojo 106 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/utility/tests/run_loop_unittest.cc ('k') | mojo/services/clipboard/clipboard_standalone_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698