mojo/shell/shell_test_base_unittest.cc - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/shell_test_base_unittest.cc

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/shell/shell_test_base_unittest.cc

diff --git a/mojo/shell/shell_test_base_unittest.cc b/mojo/shell/shell_test_base_unittest.cc

index 9b1a6c15258f99af24a3517704502f6f85093cc2..6c65ba8a5d15b121dddff7d5a1dd32443daba69c 100644

--- a/mojo/shell/shell_test_base_unittest.cc

+++ b/mojo/shell/shell_test_base_unittest.cc

@@ -74,10 +74,10 @@ class ShellTestBaseTest : public ShellTestBase {

class QuitMessageLoopErrorHandler : public ErrorHandler {

public:

QuitMessageLoopErrorHandler() {}

- virtual ~QuitMessageLoopErrorHandler() {}

+ ~QuitMessageLoopErrorHandler() override {}

// |ErrorHandler| implementation:

- virtual void OnConnectionError() override {

+ void OnConnectionError() override {

base::MessageLoop::current()->QuitWhenIdle();

}

« no previous file with comments | « mojo/shell/out_of_process_dynamic_service_runner.h ('k') | mojo/shell/test_child_process.h » ('j') | no next file with comments »