Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: mojo/common/message_pump_mojo_unittest.cc

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/message_pump_mojo.h ('k') | mojo/converters/input_events/mojo_extended_key_event_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/message_pump_mojo_unittest.cc
diff --git a/mojo/common/message_pump_mojo_unittest.cc b/mojo/common/message_pump_mojo_unittest.cc
index f34013250853b5eb77adc8af0759a799d39ce44f..09cbe54a63a1e7441d96b86373ad94ec029bee13 100644
--- a/mojo/common/message_pump_mojo_unittest.cc
+++ b/mojo/common/message_pump_mojo_unittest.cc
@@ -24,7 +24,7 @@ class CountingMojoHandler : public MessagePumpMojoHandler {
public:
CountingMojoHandler() : success_count_(0), error_count_(0) {}
- virtual void OnHandleReady(const Handle& handle) override {
+ void OnHandleReady(const Handle& handle) override {
ReadMessageRaw(static_cast<const MessagePipeHandle&>(handle),
NULL,
NULL,
@@ -33,7 +33,7 @@ class CountingMojoHandler : public MessagePumpMojoHandler {
MOJO_READ_MESSAGE_FLAG_NONE);
++success_count_;
}
- virtual void OnHandleError(const Handle& handle, MojoResult result) override {
+ void OnHandleError(const Handle& handle, MojoResult result) override {
++error_count_;
}
@@ -49,12 +49,8 @@ class CountingMojoHandler : public MessagePumpMojoHandler {
class CountingObserver : public MessagePumpMojo::Observer {
public:
- virtual void WillSignalHandler() override {
- will_signal_handler_count++;
- }
- virtual void DidSignalHandler() override {
- did_signal_handler_count++;
- }
+ void WillSignalHandler() override { will_signal_handler_count++; }
+ void DidSignalHandler() override { did_signal_handler_count++; }
int will_signal_handler_count = 0;
int did_signal_handler_count = 0;
« no previous file with comments | « mojo/common/message_pump_mojo.h ('k') | mojo/converters/input_events/mojo_extended_key_event_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698