mojo/apps/js/content_handler_impl.cc - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/content_handler_impl.cc

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/apps/js/content_handler_impl.cc

diff --git a/mojo/apps/js/content_handler_impl.cc b/mojo/apps/js/content_handler_impl.cc

index 01897a0b7a1692fa2be96d5522994e7d325d20dd..233e8af179d49f9acaecd56a75eae776fb7510b4 100644

--- a/mojo/apps/js/content_handler_impl.cc

+++ b/mojo/apps/js/content_handler_impl.cc

@@ -19,7 +19,7 @@ class ContentHandlerJSApp : public JSApp {

content_(content.Pass()) {

}

- virtual bool Load(std::string* source, std::string* file_name) override {

+ bool Load(std::string* source, std::string* file_name) override {

*file_name = content_->url;

if (content_.is_null())

return false;

« no previous file with comments | « mojo/apps/js/content_handler_impl.h ('k') | mojo/apps/js/content_handler_main.cc » ('j') | no next file with comments »