mojo/apps/js/content_handler_impl.h - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/content_handler_impl.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/apps/js/content_handler_impl.h

diff --git a/mojo/apps/js/content_handler_impl.h b/mojo/apps/js/content_handler_impl.h

index 04c2603924361c7f6a0a4d73d687c858dbf8e4f7..925d4959e6bcf6a0a5f25d5bcb464910da15e947 100644

--- a/mojo/apps/js/content_handler_impl.h

+++ b/mojo/apps/js/content_handler_impl.h

@@ -18,11 +18,10 @@ class ContentHandlerImpl : public InterfaceImpl<ContentHandler> {

ContentHandlerImpl(ApplicationDelegateImpl* app_delegate_impl);

private:

- virtual ~ContentHandlerImpl();

- virtual void OnConnect(

- const mojo::String& url,

- URLResponsePtr content,

- InterfaceRequest<ServiceProvider> service_provider) override;

+ ~ContentHandlerImpl() override;

+ void OnConnect(const mojo::String& url,

+ URLResponsePtr content,

+ InterfaceRequest<ServiceProvider> service_provider) override;

ApplicationDelegateImpl* app_delegate_impl_;

};

« no previous file with comments | « mojo/apps/js/bindings/gl/context.h ('k') | mojo/apps/js/content_handler_impl.cc » ('j') | no next file with comments »