mojo/public/cpp/system/tests/macros_unittest.cc - Issue 668663006: Standardize usage of virtual/override/final in mojo/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/system/tests/macros_unittest.cc

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/system/tests/macros_unittest.cc

diff --git a/mojo/public/cpp/system/tests/macros_unittest.cc b/mojo/public/cpp/system/tests/macros_unittest.cc

index bca8af769b1ceb2c8e10d49c16faa60c0bddffa2..99b158dabe10dd3a39bcef6827f3c28b35b0c553 100644

--- a/mojo/public/cpp/system/tests/macros_unittest.cc

+++ b/mojo/public/cpp/system/tests/macros_unittest.cc

@@ -30,9 +30,9 @@ struct TestOverrideBaseClass {

};

struct TestOverrideSubclass : public TestOverrideBaseClass {

- virtual ~TestOverrideSubclass() {}

- virtual void ToBeOverridden() override {}

- virtual void AlsoToBeOverridden() override {}

+ ~TestOverrideSubclass() override {}

+ void ToBeOverridden() override {}

+ void AlsoToBeOverridden() override {}

};

TEST(MacrosCppTest, Override) {

« no previous file with comments | « mojo/public/cpp/environment/lib/default_async_waiter.cc ('k') | mojo/public/cpp/utility/tests/mutex_unittest.cc » ('j') | no next file with comments »