Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: mojo/shell/app_child_process.cc

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/app_child_process.h ('k') | mojo/shell/app_child_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/app_child_process.cc
diff --git a/mojo/shell/app_child_process.cc b/mojo/shell/app_child_process.cc
index 7bf5420cfcaea073ae895b23d1a0685a0c92417a..79aaa49e8040492381a2e53cb49db160f6af3751 100644
--- a/mojo/shell/app_child_process.cc
+++ b/mojo/shell/app_child_process.cc
@@ -157,7 +157,7 @@ class AppContext {
class AppChildControllerImpl : public InterfaceImpl<AppChildController> {
public:
- virtual ~AppChildControllerImpl() {
+ ~AppChildControllerImpl() override {
DCHECK(thread_checker_.CalledOnValidThread());
// TODO(vtl): Pass in the result from |MainMain()|.
@@ -190,13 +190,13 @@ class AppChildControllerImpl : public InterfaceImpl<AppChildController> {
app_context->set_controller(impl.Pass());
}
- virtual void OnConnectionError() override {
+ void OnConnectionError() override {
// TODO(darin): How should we handle a connection error here?
}
// |AppChildController| methods:
- virtual void StartApp(const String& app_path,
- ScopedMessagePipeHandle service) override {
+ void StartApp(const String& app_path,
+ ScopedMessagePipeHandle service) override {
DVLOG(2) << "AppChildControllerImpl::StartApp(" << app_path << ", ...)";
DCHECK(thread_checker_.CalledOnValidThread());
« no previous file with comments | « mojo/shell/app_child_process.h ('k') | mojo/shell/app_child_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698