Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: mojo/application_manager/background_shell_application_loader.h

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_ 5 #ifndef MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_
6 #define MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_ 6 #define MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "base/synchronization/waitable_event.h" 11 #include "base/synchronization/waitable_event.h"
12 #include "base/threading/simple_thread.h" 12 #include "base/threading/simple_thread.h"
13 #include "mojo/application_manager/application_loader.h" 13 #include "mojo/application_manager/application_loader.h"
14 14
15 namespace mojo { 15 namespace mojo {
16 16
17 // TODO(tim): Eventually this should be Android-only to support services 17 // TODO(tim): Eventually this should be Android-only to support services
18 // that we need to bundle with the shell (such as NetworkService). Perhaps 18 // that we need to bundle with the shell (such as NetworkService). Perhaps
19 // we should move it to shell/ as well. 19 // we should move it to shell/ as well.
20 class MOJO_APPLICATION_MANAGER_EXPORT BackgroundShellApplicationLoader 20 class MOJO_APPLICATION_MANAGER_EXPORT BackgroundShellApplicationLoader
21 : public ApplicationLoader, 21 : public ApplicationLoader,
22 public base::DelegateSimpleThread::Delegate { 22 public base::DelegateSimpleThread::Delegate {
23 public: 23 public:
24 BackgroundShellApplicationLoader(scoped_ptr<ApplicationLoader> real_loader, 24 BackgroundShellApplicationLoader(scoped_ptr<ApplicationLoader> real_loader,
25 const std::string& thread_name, 25 const std::string& thread_name,
26 base::MessageLoop::Type message_loop_type); 26 base::MessageLoop::Type message_loop_type);
27 virtual ~BackgroundShellApplicationLoader(); 27 ~BackgroundShellApplicationLoader() override;
28 28
29 // ApplicationLoader overrides: 29 // ApplicationLoader overrides:
30 virtual void Load(ApplicationManager* manager, 30 void Load(ApplicationManager* manager,
31 const GURL& url, 31 const GURL& url,
32 scoped_refptr<LoadCallbacks> callbacks) override; 32 scoped_refptr<LoadCallbacks> callbacks) override;
33 virtual void OnApplicationError(ApplicationManager* manager, 33 void OnApplicationError(ApplicationManager* manager,
34 const GURL& url) override; 34 const GURL& url) override;
35 35
36 private: 36 private:
37 class BackgroundLoader; 37 class BackgroundLoader;
38 38
39 // |base::DelegateSimpleThread::Delegate| method: 39 // |base::DelegateSimpleThread::Delegate| method:
40 virtual void Run() override; 40 void Run() override;
41 41
42 // These functions are exected on the background thread. They call through 42 // These functions are exected on the background thread. They call through
43 // to |background_loader_| to do the actual loading. 43 // to |background_loader_| to do the actual loading.
44 // TODO: having this code take a |manager| is fragile (as ApplicationManager 44 // TODO: having this code take a |manager| is fragile (as ApplicationManager
45 // isn't thread safe). 45 // isn't thread safe).
46 void LoadOnBackgroundThread(ApplicationManager* manager, 46 void LoadOnBackgroundThread(ApplicationManager* manager,
47 const GURL& url, 47 const GURL& url,
48 ScopedMessagePipeHandle* shell_handle); 48 ScopedMessagePipeHandle* shell_handle);
49 void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager, 49 void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager,
50 const GURL& url); 50 const GURL& url);
(...skipping 17 matching lines...) Expand all
68 68
69 // Lives on |thread_|. Trivial interface that calls through to |loader_|. 69 // Lives on |thread_|. Trivial interface that calls through to |loader_|.
70 BackgroundLoader* background_loader_; 70 BackgroundLoader* background_loader_;
71 71
72 DISALLOW_COPY_AND_ASSIGN(BackgroundShellApplicationLoader); 72 DISALLOW_COPY_AND_ASSIGN(BackgroundShellApplicationLoader);
73 }; 73 };
74 74
75 } // namespace mojo 75 } // namespace mojo
76 76
77 #endif // MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_ 77 #endif // MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698