Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: mojo/public/cpp/utility/tests/mutex_unittest.cc

Issue 668663006: Standardize usage of virtual/override/final in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/system/tests/macros_unittest.cc ('k') | mojo/public/cpp/utility/tests/run_loop_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/utility/tests/mutex_unittest.cc
diff --git a/mojo/public/cpp/utility/tests/mutex_unittest.cc b/mojo/public/cpp/utility/tests/mutex_unittest.cc
index a95495e076c8f9b02d3b3fd1278930ed1d42d160..d6f75da574a0dbfdb25c62cc8d6e9ad86581d8c5 100644
--- a/mojo/public/cpp/utility/tests/mutex_unittest.cc
+++ b/mojo/public/cpp/utility/tests/mutex_unittest.cc
@@ -111,11 +111,9 @@ class FiddlerThread : public Thread {
: fiddler_(fiddler) {
}
- virtual ~FiddlerThread() {
- delete fiddler_;
- }
+ ~FiddlerThread() override { delete fiddler_; }
- virtual void Run() override { fiddler_->Fiddle(); }
+ void Run() override { fiddler_->Fiddle(); }
private:
Fiddler* const fiddler_;
@@ -167,9 +165,9 @@ TEST(MutexTest, ThreadedStress) {
class TryThread : public Thread {
public:
explicit TryThread(Mutex* mutex) : mutex_(mutex), try_lock_succeeded_() {}
- virtual ~TryThread() {}
+ ~TryThread() override {}
- virtual void Run() override {
+ void Run() override {
try_lock_succeeded_ = mutex_->TryLock();
if (try_lock_succeeded_)
mutex_->Unlock();
« no previous file with comments | « mojo/public/cpp/system/tests/macros_unittest.cc ('k') | mojo/public/cpp/utility/tests/run_loop_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698