Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, apacible+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, erickung+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, ios-reviews_chromium.org, jam, jshin+watch_chromium.org, lcwu+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MediaLog from being ref counted to owned by WebMediaPlayer. MediaLog instances are always bound to a specific player, so there's no reason for having it be ref-counted other than to confuse folk into thinking it can be reused. There seems to be no reason why this was ref counted. There were a couple questionable places, WebSourceBufferImpl and WebMediaPlayerMSCompositor, but neither is really using the MediaLog so I either removed it or replaced it with a dummy log. The RendererFactories are a bit questionable too, but they are owned by the WebMediaPlayerImpl so should be fine. BUG=711818, 712310 TEST=compiles, nothing crashes, existing tests still pass. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2815303006 Cr-Commit-Position: refs/heads/master@{#465753} Committed: https://chromium.googlesource.com/chromium/src/+/9cddc0b9cd174242d365e9d64615687384b73c89

Patch Set 1 #

Patch Set 2 : Fix heap allocations. #

Patch Set 3 : Fix cast, fuzzers. #

Total comments: 2

Patch Set 4 : Actually fix cast... #

Patch Set 5 : Actually fix fuzzers. #

Total comments: 8

Patch Set 6 : Address comments. #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -629 lines) Patch
M chromecast/media/cma/decoder/cast_audio_decoder_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/media/cma/test/frame_segmenter_for_test.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chromecast/media/service/cast_mojo_media_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/service/cast_mojo_media_client.cc View 1 2 3 4 5 3 chunks +3 lines, -7 lines 0 comments Download
M content/browser/media/media_internals_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/render_media_log.h View 4 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/render_media_log.cc View 5 chunks +23 lines, -7 lines 0 comments Download
M content/renderer/media/render_media_log_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.h View 4 chunks +6 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 6 chunks +27 lines, -27 lines 0 comments Download
M media/base/demuxer_perftest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/base/media_log.h View 5 chunks +5 lines, -10 lines 0 comments Download
M media/base/media_log.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/base/mock_filters.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mock_media_log.h View 2 chunks +4 lines, -6 lines 0 comments Download
M media/base/pipeline_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/stream_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/multibuffer_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/blink/watch_time_reporter.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/watch_time_reporter.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M media/blink/watch_time_reporter_unittest.cc View 1 4 chunks +7 lines, -9 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/blink/webencryptedmediaclient_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 4 5 6 12 chunks +34 lines, -34 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M media/blink/webmediaplayer_params.h View 1 2 3 4 5 5 chunks +4 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_params.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webmediasource_impl.h View 3 chunks +1 line, -4 lines 0 comments Download
M media/blink/webmediasource_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M media/filters/audio_decoder_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/audio_timestamp_validator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/audio_timestamp_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_timestamp_validator_unittest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 2 3 4 5 3 chunks +5 lines, -8 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 2 3 4 5 4 chunks +7 lines, -10 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 3 4 5 3 chunks +4 lines, -6 lines 0 comments Download
M media/filters/decoder_selector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decoder_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decoder_stream.h View 2 chunks +4 lines, -5 lines 0 comments Download
M media/filters/decoder_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decoder_stream_traits.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/filters/decoder_stream_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/decrypting_demuxer_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decrypting_demuxer_stream_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/decrypting_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 2 3 4 5 5 chunks +7 lines, -8 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/filters/frame_processor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/frame_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/frame_processor_unittest.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/source_buffer_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/source_buffer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_state_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M media/filters/source_buffer_stream.h View 2 chunks +4 lines, -5 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M media/filters/stream_parser_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/stream_parser_factory.cc View 1 11 chunks +18 lines, -17 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/video_renderer_algorithm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_renderer_algorithm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/video_renderer_algorithm_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/common/stream_parser_test_base.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M media/formats/common/stream_parser_test_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp2t/es_parser_mpeg1audio.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/mp2t/es_parser_mpeg1audio.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/formats/mp2t/es_parser_mpeg1audio_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp2t/mp2t_stream_parser_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/mp4/aac.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp4/aac.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp4/aac_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/formats/mp4/box_definitions.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp4/box_definitions.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M media/formats/mp4/box_reader.h View 5 chunks +6 lines, -7 lines 0 comments Download
M media/formats/mp4/box_reader.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M media/formats/mp4/box_reader_unittest.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M media/formats/mp4/dolby_vision.h View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M media/formats/mp4/dolby_vision.cc View 1 2 3 4 5 1 chunk +6 lines, -5 lines 0 comments Download
M media/formats/mp4/dolby_vision_unittest.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M media/formats/mp4/hevc.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp4/hevc.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp4/mp4_stream_parser_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M media/formats/mp4/track_run_iterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/mp4/track_run_iterator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/formats/mp4/track_run_iterator_unittest.cc View 18 chunks +20 lines, -22 lines 0 comments Download
M media/formats/mpeg/mpeg1_audio_stream_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mpeg/mpeg1_audio_stream_parser.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M media/formats/mpeg/mpeg_audio_stream_parser_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/formats/mpeg/mpeg_audio_stream_parser_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_audio_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_audio_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/webm/webm_cluster_parser.h View 4 chunks +4 lines, -4 lines 0 comments Download
M media/formats/webm/webm_cluster_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_cluster_parser_unittest.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M media/formats/webm/webm_content_encodings_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_content_encodings_client.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/formats/webm/webm_content_encodings_client_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/formats/webm/webm_stream_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_stream_parser_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M media/formats/webm/webm_tracks_parser.h View 2 chunks +2 lines, -3 lines 0 comments Download
M media/formats/webm/webm_tracks_parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/webm/webm_tracks_parser_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M media/formats/webm/webm_video_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_video_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/services/interface_factory_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/interface_factory_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/mojo/services/media_service.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_service.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/test_mojo_media_client.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/test_mojo_media_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M media/renderers/default_renderer_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/video_renderer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 4 chunks +47 lines, -45 lines 0 comments Download
M testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc View 1 2 3 4 2 chunks +7 lines, -11 lines 0 comments Download
M testing/libfuzzer/fuzzers/mp4_box_reader_fuzzer.cc View 1 2 3 4 2 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 61 (36 generated)
DaleCurtis
-> xhwang for first pass at media/, this is mostly mechanical (\o/ for sed and ...
3 years, 8 months ago (2017-04-15 00:45:31 UTC) #3
DaleCurtis
Hmm, missed a bunch of New XXX instances, some of which are questionable, so hold ...
3 years, 8 months ago (2017-04-17 20:18:46 UTC) #9
DaleCurtis
Okay latest patch set should resolve the last of the test/build failures. +nick for content/renderer ...
3 years, 8 months ago (2017-04-17 22:04:42 UTC) #17
DaleCurtis
Oh and +krasin for testing/libfuzzer/ changes.
3 years, 8 months ago (2017-04-17 22:06:53 UTC) #22
ncarter (slow)
content (ex content/media) lgtm
3 years, 8 months ago (2017-04-17 22:16:00 UTC) #23
krasin1
lgtm LGTM for libfuzzer.
3 years, 8 months ago (2017-04-17 22:40:48 UTC) #28
DaleCurtis
Fuzzers actually needed a bit more work, I cleaned up some cruft at the same ...
3 years, 8 months ago (2017-04-17 23:25:21 UTC) #31
slan
https://codereview.chromium.org/2815303006/diff/40001/chromecast/media/service/cast_mojo_media_client.cc File chromecast/media/service/cast_mojo_media_client.cc (right): https://codereview.chromium.org/2815303006/diff/40001/chromecast/media/service/cast_mojo_media_client.cc#newcode65 chromecast/media/service/cast_mojo_media_client.cc:65: media_log_(media_log), Does this compile? Looks like this should throw ...
3 years, 8 months ago (2017-04-17 23:27:10 UTC) #32
DaleCurtis
https://codereview.chromium.org/2815303006/diff/40001/chromecast/media/service/cast_mojo_media_client.cc File chromecast/media/service/cast_mojo_media_client.cc (right): https://codereview.chromium.org/2815303006/diff/40001/chromecast/media/service/cast_mojo_media_client.cc#newcode65 chromecast/media/service/cast_mojo_media_client.cc:65: media_log_(media_log), On 2017/04/17 at 23:27:10, slan wrote: > Does ...
3 years, 8 months ago (2017-04-17 23:28:50 UTC) #33
xhwang
I am busy today so I won't have time looking at this today. I'll take ...
3 years, 8 months ago (2017-04-17 23:35:46 UTC) #34
DaleCurtis
No worries, Chris said he might have time today, so +chcunningham in case he gets ...
3 years, 8 months ago (2017-04-17 23:38:40 UTC) #36
xhwang
hmm, if you don't plan to merge this back to M59, could this CL wait ...
3 years, 8 months ago (2017-04-17 23:43:07 UTC) #39
DaleCurtis
Your VideoHeight patch applies cleanly on top of this, so it shouldn't be an issue. ...
3 years, 8 months ago (2017-04-17 23:46:52 UTC) #40
xhwang
On 2017/04/17 23:46:52, DaleCurtis wrote: > Your VideoHeight patch applies cleanly on top of this, ...
3 years, 8 months ago (2017-04-17 23:57:12 UTC) #41
krasin1
Still LGTM for fuzzers.
3 years, 8 months ago (2017-04-18 20:13:02 UTC) #44
slan
cast lgtm
3 years, 8 months ago (2017-04-18 20:43:23 UTC) #45
chcunningham
https://codereview.chromium.org/2815303006/diff/80001/chromecast/media/service/cast_mojo_media_client.cc File chromecast/media/service/cast_mojo_media_client.cc (right): https://codereview.chromium.org/2815303006/diff/80001/chromecast/media/service/cast_mojo_media_client.cc#newcode60 chromecast/media/service/cast_mojo_media_client.cc:60: ::media::MediaLog* media_log, should we just kill the arg since ...
3 years, 8 months ago (2017-04-18 23:29:13 UTC) #46
DaleCurtis
https://codereview.chromium.org/2815303006/diff/80001/chromecast/media/service/cast_mojo_media_client.cc File chromecast/media/service/cast_mojo_media_client.cc (right): https://codereview.chromium.org/2815303006/diff/80001/chromecast/media/service/cast_mojo_media_client.cc#newcode60 chromecast/media/service/cast_mojo_media_client.cc:60: ::media::MediaLog* media_log, On 2017/04/18 at 23:29:12, chcunningham wrote: > ...
3 years, 8 months ago (2017-04-18 23:55:45 UTC) #47
DaleCurtis
https://codereview.chromium.org/2815303006/diff/80001/chromecast/media/service/cast_mojo_media_client.cc File chromecast/media/service/cast_mojo_media_client.cc (right): https://codereview.chromium.org/2815303006/diff/80001/chromecast/media/service/cast_mojo_media_client.cc#newcode60 chromecast/media/service/cast_mojo_media_client.cc:60: ::media::MediaLog* media_log, On 2017/04/18 at 23:29:12, chcunningham wrote: > ...
3 years, 8 months ago (2017-04-18 23:55:46 UTC) #48
chcunningham
LGTM
3 years, 8 months ago (2017-04-19 00:46:16 UTC) #49
DaleCurtis
Thanks for review!
3 years, 8 months ago (2017-04-19 00:52:45 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815303006/100001
3 years, 8 months ago (2017-04-19 00:53:17 UTC) #53
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/425252)
3 years, 8 months ago (2017-04-19 00:59:18 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815303006/120001
3 years, 8 months ago (2017-04-19 17:21:13 UTC) #58
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 21:23:59 UTC) #61
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/9cddc0b9cd174242d365e9d64615...

Powered by Google App Engine
This is Rietveld 408576698