Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: media/renderers/video_renderer_impl_unittest.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/renderers/video_renderer_impl.cc ('k') | media/test/pipeline_integration_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/video_renderer_impl_unittest.cc
diff --git a/media/renderers/video_renderer_impl_unittest.cc b/media/renderers/video_renderer_impl_unittest.cc
index 259fcef7fa0e1c1fb7e414e668f9784c1ca51625..282c264fb21d3a169d4e761347902dbeaf361f11 100644
--- a/media/renderers/video_renderer_impl_unittest.cc
+++ b/media/renderers/video_renderer_impl_unittest.cc
@@ -85,7 +85,7 @@ class VideoRendererImplTest : public testing::Test {
base::Unretained(this)),
true,
nullptr, // gpu_factories
- new MediaLog()));
+ &media_log_));
renderer_->SetTickClockForTesting(
std::unique_ptr<base::TickClock>(tick_clock_));
null_video_sink_->set_tick_clock_for_testing(tick_clock_);
@@ -439,6 +439,9 @@ class VideoRendererImplTest : public testing::Test {
}
protected:
+ base::MessageLoop message_loop_;
+ MediaLog media_log_;
+
// Fixture members.
std::unique_ptr<VideoRendererImpl> renderer_;
base::SimpleTestTickClock* tick_clock_; // Owned by |renderer_|.
@@ -459,8 +462,6 @@ class VideoRendererImplTest : public testing::Test {
WallClockTimeSource time_source_;
- base::MessageLoop message_loop_;
-
private:
void DecodeRequested(const scoped_refptr<DecoderBuffer>& buffer,
const VideoDecoder::DecodeCB& decode_cb) {
« no previous file with comments | « media/renderers/video_renderer_impl.cc ('k') | media/test/pipeline_integration_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698