Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: media/filters/video_decoder_selector_unittest.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/stream_parser_factory.cc ('k') | media/filters/video_frame_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_decoder_selector_unittest.cc
diff --git a/media/filters/video_decoder_selector_unittest.cc b/media/filters/video_decoder_selector_unittest.cc
index c7563242eda259621111e8174236a883dc381910..9743f58488af0b37588f7fcb7ad863b3882f4fc8 100644
--- a/media/filters/video_decoder_selector_unittest.cc
+++ b/media/filters/video_decoder_selector_unittest.cc
@@ -50,8 +50,7 @@ class VideoDecoderSelectorTest : public ::testing::Test {
};
VideoDecoderSelectorTest()
- : media_log_(new MediaLog()),
- traits_(media_log_),
+ : traits_(&media_log_),
demuxer_stream_(
new StrictMock<MockDemuxerStream>(DemuxerStream::VIDEO)),
decoder_1_(new StrictMock<MockVideoDecoder>()),
@@ -105,7 +104,7 @@ class VideoDecoderSelectorTest : public ::testing::Test {
all_decoders_.begin() + num_decoders, all_decoders_.end());
decoder_selector_.reset(new VideoDecoderSelector(
- message_loop_.task_runner(), std::move(all_decoders_), media_log_));
+ message_loop_.task_runner(), std::move(all_decoders_), &media_log_));
}
void SelectDecoder() {
@@ -136,7 +135,7 @@ class VideoDecoderSelectorTest : public ::testing::Test {
NOTREACHED();
}
- scoped_refptr<MediaLog> media_log_;
+ MediaLog media_log_;
// Stream traits specific to video decoding.
DecoderStreamTraits<DemuxerStream::VIDEO> traits_;
« no previous file with comments | « media/filters/stream_parser_factory.cc ('k') | media/filters/video_frame_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698