Convert MediaLog from being ref counted to owned by WebMediaPlayer.

media/formats/mp4/hevc.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/mp4/hevc.h"
 
 #include <algorithm>
 #include <memory>
 #include <utility>
 #include <vector>
@@ skipping 30 matching lines @@
 
 HEVCDecoderConfigurationRecord::~HEVCDecoderConfigurationRecord() {}
 FourCC HEVCDecoderConfigurationRecord::BoxType() const { return FOURCC_HVCC; }
 
 bool HEVCDecoderConfigurationRecord::Parse(BoxReader* reader) {
   return ParseInternal(reader, reader->media_log());
 }
 
 bool HEVCDecoderConfigurationRecord::Parse(const uint8_t* data, int data_size) {
   BufferReader reader(data, data_size);
-  return ParseInternal(&reader, new MediaLog());
+  // TODO(wolenetz): Questionable MediaLog usage, http://crbug.com/712310
+  MediaLog media_log;
+  return ParseInternal(&reader, &media_log);

[chcunningham, 2017/04/18 23:29:12]

same story - should be easy to fix this one

[DaleCurtis, 2017/04/18 23:55:46]

This one's actually used by
https://cs.chromium.org/chromium/src/media/filters/ffmpeg_h265_to_annex_b_bit...
which does not currently have a media_log.

 }
 
 HEVCDecoderConfigurationRecord::HVCCNALArray::HVCCNALArray()
     : first_byte(0) {}
 
 HEVCDecoderConfigurationRecord::HVCCNALArray::HVCCNALArray(
     const HVCCNALArray& other) = default;
 
 HEVCDecoderConfigurationRecord::HVCCNALArray::~HVCCNALArray() {}
 
-bool HEVCDecoderConfigurationRecord::ParseInternal(
-    BufferReader* reader,
-    const scoped_refptr<MediaLog>& media_log) {
+bool HEVCDecoderConfigurationRecord::ParseInternal(BufferReader* reader,
+                                                   MediaLog* media_log) {
   uint8_t profile_indication = 0;
   uint32_t general_constraint_indicator_flags_hi = 0;
   uint16_t general_constraint_indicator_flags_lo = 0;
   uint8_t misc = 0;
   RCHECK(reader->Read1(&configurationVersion) && configurationVersion == 1 &&
          reader->Read1(&profile_indication) &&
          reader->Read4(&general_profile_compatibility_flags) &&
          reader->Read4(&general_constraint_indicator_flags_hi) &&
          reader->Read2(&general_constraint_indicator_flags_lo) &&
          reader->Read1(&general_level_idc) &&
@@ skipping 168 matching lines @@
     // count for that first subsample.
     RCHECK(HEVC::InsertParamSetsAnnexB(*hevc_config_, frame_buf, subsamples));
   }
 
   DCHECK(HEVC::IsValidAnnexB(*frame_buf, *subsamples));
   return true;
 }
 
 }  // namespace mp4
 }  // namespace media