Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chromecast/media/service/cast_mojo_media_client.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/service/cast_mojo_media_client.cc
diff --git a/chromecast/media/service/cast_mojo_media_client.cc b/chromecast/media/service/cast_mojo_media_client.cc
index 3fc985b15072080fe6332642a68817eb25c4ae96..d8e4fbba6dbaecb72a477e15a437e1c183f4fa67 100644
--- a/chromecast/media/service/cast_mojo_media_client.cc
+++ b/chromecast/media/service/cast_mojo_media_client.cc
@@ -57,12 +57,10 @@ class CastAudioRendererSink : public ::media::AudioRendererSink {
class CastRendererFactory : public ::media::RendererFactory {
public:
CastRendererFactory(MediaPipelineBackendFactory* backend_factory,
- const scoped_refptr<::media::MediaLog>& media_log,
VideoModeSwitcher* video_mode_switcher,
VideoResolutionPolicy* video_resolution_policy,
MediaResourceTracker* media_resource_tracker)
: backend_factory_(backend_factory),
- media_log_(media_log),
video_mode_switcher_(video_mode_switcher),
video_resolution_policy_(video_resolution_policy),
media_resource_tracker_(media_resource_tracker) {}
@@ -85,7 +83,6 @@ class CastRendererFactory : public ::media::RendererFactory {
private:
MediaPipelineBackendFactory* const backend_factory_;
- scoped_refptr<::media::MediaLog> media_log_;
VideoModeSwitcher* video_mode_switcher_;
VideoResolutionPolicy* video_resolution_policy_;
MediaResourceTracker* media_resource_tracker_;
@@ -123,11 +120,10 @@ CastMojoMediaClient::CreateAudioRendererSink(
}
std::unique_ptr<::media::RendererFactory>
-CastMojoMediaClient::CreateRendererFactory(
- const scoped_refptr<::media::MediaLog>& media_log) {
+CastMojoMediaClient::CreateRendererFactory(::media::MediaLog* /* media_log */) {
return base::MakeUnique<CastRendererFactory>(
- backend_factory_, media_log, video_mode_switcher_,
- video_resolution_policy_, media_resource_tracker_);
+ backend_factory_, video_mode_switcher_, video_resolution_policy_,
+ media_resource_tracker_);
}
std::unique_ptr<::media::CdmFactory> CastMojoMediaClient::CreateCdmFactory(
« no previous file with comments | « chromecast/media/service/cast_mojo_media_client.h ('k') | content/browser/media/media_internals_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698