media/blink/watch_time_reporter.cc - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/watch_time_reporter.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/watch_time_reporter.cc

diff --git a/media/blink/watch_time_reporter.cc b/media/blink/watch_time_reporter.cc

index b0127d749181380c611f089bf94ebca97db623f0..cad61c42fc1c7ef140f2f3c2ceba449e3958b1fd 100644

--- a/media/blink/watch_time_reporter.cc

+++ b/media/blink/watch_time_reporter.cc

@@ -27,7 +27,7 @@ WatchTimeReporter::WatchTimeReporter(bool has_audio,

bool is_mse,

bool is_encrypted,

bool is_embedded_media_experience_enabled,

- scoped_refptr<MediaLog> media_log,

+ MediaLog* media_log,

const gfx::Size& initial_video_size,

const GetMediaTimeCB& get_media_time_cb)

: WatchTimeReporter(has_audio,

@@ -35,7 +35,7 @@ WatchTimeReporter::WatchTimeReporter(bool has_audio,

is_mse,

is_encrypted,

is_embedded_media_experience_enabled,

- std::move(media_log),

+ media_log,

initial_video_size,

get_media_time_cb,

false) {}

@@ -45,7 +45,7 @@ WatchTimeReporter::WatchTimeReporter(bool has_audio,

bool is_mse,

bool is_encrypted,

bool is_embedded_media_experience_enabled,

- scoped_refptr<MediaLog> media_log,

+ MediaLog* media_log,

const gfx::Size& initial_video_size,

const GetMediaTimeCB& get_media_time_cb,

bool is_background)

@@ -55,7 +55,7 @@ WatchTimeReporter::WatchTimeReporter(bool has_audio,

is_encrypted_(is_encrypted),

is_embedded_media_experience_enabled_(

is_embedded_media_experience_enabled),

- media_log_(std::move(media_log)),

+ media_log_(media_log),

initial_video_size_(initial_video_size),

get_media_time_cb_(get_media_time_cb),

is_background_(is_background) {

« no previous file with comments | « media/blink/watch_time_reporter.h ('k') | media/blink/watch_time_reporter_unittest.cc » ('j') | no next file with comments »