media/filters/video_renderer_algorithm.cc - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_algorithm.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/video_renderer_algorithm.cc

diff --git a/media/filters/video_renderer_algorithm.cc b/media/filters/video_renderer_algorithm.cc

index a49c107889efa1eaa04e2268acb41b91a919b5fa..32bab9759ea4da6cbfd10b8a6ad888c2bbd271ee 100644

--- a/media/filters/video_renderer_algorithm.cc

+++ b/media/filters/video_renderer_algorithm.cc

@@ -39,8 +39,8 @@ bool VideoRendererAlgorithm::ReadyFrame::operator<(

VideoRendererAlgorithm::VideoRendererAlgorithm(

const TimeSource::WallClockTimeCB& wall_clock_time_cb,

- scoped_refptr<MediaLog> media_log)

- : media_log_(std::move(media_log)),

+ MediaLog* media_log)

+ : media_log_(media_log),

cadence_estimator_(base::TimeDelta::FromSeconds(

kMinimumAcceptableTimeBetweenGlitchesSecs)),

wall_clock_time_cb_(wall_clock_time_cb),