Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: content/renderer/media/render_media_log.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_RENDER_MEDIA_LOG_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_RENDER_MEDIA_LOG_H_
6 #define CONTENT_RENDERER_MEDIA_RENDER_MEDIA_LOG_H_ 6 #define CONTENT_RENDERER_MEDIA_RENDER_MEDIA_LOG_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/weak_ptr.h"
12 #include "base/synchronization/lock.h" 13 #include "base/synchronization/lock.h"
13 #include "base/time/time.h" 14 #include "base/time/time.h"
14 #include "content/common/content_export.h" 15 #include "content/common/content_export.h"
15 #include "media/base/media_log.h" 16 #include "media/base/media_log.h"
16 #include "url/gurl.h" 17 #include "url/gurl.h"
17 18
18 namespace base { 19 namespace base {
19 class TickClock; 20 class TickClock;
20 } 21 }
21 22
22 namespace content { 23 namespace content {
23 24
24 // RenderMediaLog is an implementation of MediaLog that forwards events to the 25 // RenderMediaLog is an implementation of MediaLog that forwards events to the
25 // browser process, throttling as necessary. 26 // browser process, throttling as necessary.
26 // 27 //
27 // It also caches the last error events to support renderer-side reporting to 28 // It also caches the last error events to support renderer-side reporting to
28 // entities like HTMLMediaElement and devtools console. 29 // entities like HTMLMediaElement and devtools console.
29 // 30 //
30 // To minimize the number of events sent over the wire, only the latest event 31 // To minimize the number of events sent over the wire, only the latest event
31 // added is sent for high frequency events (e.g., BUFFERED_EXTENTS_CHANGED). 32 // added is sent for high frequency events (e.g., BUFFERED_EXTENTS_CHANGED).
32 // 33 //
33 // It must be constructed on the render thread. 34 // It must be constructed on the render thread.
34 class CONTENT_EXPORT RenderMediaLog : public media::MediaLog { 35 class CONTENT_EXPORT RenderMediaLog : public media::MediaLog {
35 public: 36 public:
36 explicit RenderMediaLog(const GURL& security_origin); 37 explicit RenderMediaLog(const GURL& security_origin);
38 ~RenderMediaLog() override;
37 39
38 // MediaLog implementation. 40 // MediaLog implementation.
39 void AddEvent(std::unique_ptr<media::MediaLogEvent> event) override; 41 void AddEvent(std::unique_ptr<media::MediaLogEvent> event) override;
40 std::string GetLastErrorMessage() override; 42 std::string GetLastErrorMessage() override;
41 void RecordRapporWithSecurityOrigin(const std::string& metric) override; 43 void RecordRapporWithSecurityOrigin(const std::string& metric) override;
42 44
43 // Will reset |last_ipc_send_time_| with the value of NowTicks(). 45 // Will reset |last_ipc_send_time_| with the value of NowTicks().
44 void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock); 46 void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock);
45 void SetTaskRunnerForTesting( 47 void SetTaskRunnerForTesting(
46 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner); 48 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);
47 49
48 private: 50 private:
49 ~RenderMediaLog() override;
50
51 // Posted as a delayed task on |task_runner_| to throttle ipc message 51 // Posted as a delayed task on |task_runner_| to throttle ipc message
52 // frequency. 52 // frequency.
53 void SendQueuedMediaEvents(); 53 void SendQueuedMediaEvents();
54 54
55 // Security origin of the current frame. 55 // Security origin of the current frame.
56 const GURL security_origin_; 56 const GURL security_origin_;
57 57
58 scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 58 scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
59 59
60 // |lock_| protects access to all of the following member variables. It 60 // |lock_| protects access to all of the following member variables. It
(...skipping 11 matching lines...) Expand all
72 // Limits the number of events we send over IPC to one. 72 // Limits the number of events we send over IPC to one.
73 std::unique_ptr<media::MediaLogEvent> last_buffered_extents_changed_event_; 73 std::unique_ptr<media::MediaLogEvent> last_buffered_extents_changed_event_;
74 std::unique_ptr<media::MediaLogEvent> last_duration_changed_event_; 74 std::unique_ptr<media::MediaLogEvent> last_duration_changed_event_;
75 75
76 // Holds a copy of the most recent MEDIA_ERROR_LOG_ENTRY, if any. 76 // Holds a copy of the most recent MEDIA_ERROR_LOG_ENTRY, if any.
77 std::unique_ptr<media::MediaLogEvent> last_media_error_log_entry_; 77 std::unique_ptr<media::MediaLogEvent> last_media_error_log_entry_;
78 78
79 // Holds a copy of the most recent PIPELINE_ERROR, if any. 79 // Holds a copy of the most recent PIPELINE_ERROR, if any.
80 std::unique_ptr<media::MediaLogEvent> last_pipeline_error_; 80 std::unique_ptr<media::MediaLogEvent> last_pipeline_error_;
81 81
82 base::WeakPtr<RenderMediaLog> weak_this_;
83 base::WeakPtrFactory<RenderMediaLog> weak_factory_;
84
82 DISALLOW_COPY_AND_ASSIGN(RenderMediaLog); 85 DISALLOW_COPY_AND_ASSIGN(RenderMediaLog);
83 }; 86 };
84 87
85 } // namespace content 88 } // namespace content
86 89
87 #endif // CONTENT_RENDERER_MEDIA_RENDER_MEDIA_LOG_H_ 90 #endif // CONTENT_RENDERER_MEDIA_RENDER_MEDIA_LOG_H_
OLDNEW
« no previous file with comments | « content/browser/media/media_internals_unittest.cc ('k') | content/renderer/media/render_media_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698