media/blink/watch_time_reporter.h - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/watch_time_reporter.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/watch_time_reporter.h

diff --git a/media/blink/watch_time_reporter.h b/media/blink/watch_time_reporter.h

index 9b3b93bf41890581f05820c2105bd15a7e734045..9887ae27c1602dc18ae9a1f4e3ab0873af78d457 100644

--- a/media/blink/watch_time_reporter.h

+++ b/media/blink/watch_time_reporter.h

@@ -66,7 +66,7 @@ class MEDIA_BLINK_EXPORT WatchTimeReporter : base::PowerObserver {

bool is_mse,

bool is_encrypted,

bool is_embedded_media_experience_enabled,

- scoped_refptr<MediaLog> media_log,

+ MediaLog* media_log,

const gfx::Size& initial_video_size,

const GetMediaTimeCB& get_media_time_cb);

~WatchTimeReporter() override;

@@ -130,7 +130,7 @@ class MEDIA_BLINK_EXPORT WatchTimeReporter : base::PowerObserver {

bool is_mse,

bool is_encrypted,

bool is_embedded_media_experience_enabled,

- scoped_refptr<MediaLog> media_log,

+ MediaLog* media_log,

const gfx::Size& initial_video_size,

const GetMediaTimeCB& get_media_time_cb,

bool is_background);

@@ -154,7 +154,7 @@ class MEDIA_BLINK_EXPORT WatchTimeReporter : base::PowerObserver {

const bool is_mse_;

const bool is_encrypted_;

const bool is_embedded_media_experience_enabled_;

- scoped_refptr<MediaLog> media_log_;

+ MediaLog* media_log_;

const gfx::Size initial_video_size_;

const GetMediaTimeCB get_media_time_cb_;

const bool is_background_;

« no previous file with comments | « media/blink/multibuffer_data_source_unittest.cc ('k') | media/blink/watch_time_reporter.cc » ('j') | no next file with comments »