Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: content/renderer/media/render_media_log_unittest.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/render_media_log.cc ('k') | content/renderer/media/webmediaplayer_ms.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/render_media_log_unittest.cc
diff --git a/content/renderer/media/render_media_log_unittest.cc b/content/renderer/media/render_media_log_unittest.cc
index 905bec522946b54e8845c74a93134ee8ced5ba8a..e4db4d437e57fab09baff76cbb48ee855eff8248 100644
--- a/content/renderer/media/render_media_log_unittest.cc
+++ b/content/renderer/media/render_media_log_unittest.cc
@@ -18,11 +18,11 @@ namespace content {
class RenderMediaLogTest : public testing::Test {
public:
RenderMediaLogTest()
- : log_(new RenderMediaLog(GURL("http://foo.com"))),
+ : log_(GURL("http://foo.com")),
tick_clock_(new base::SimpleTestTickClock()),
task_runner_(new base::TestMockTimeTaskRunner()) {
- log_->SetTickClockForTesting(std::unique_ptr<base::TickClock>(tick_clock_));
- log_->SetTaskRunnerForTesting(task_runner_);
+ log_.SetTickClockForTesting(std::unique_ptr<base::TickClock>(tick_clock_));
+ log_.SetTaskRunnerForTesting(task_runner_);
}
~RenderMediaLogTest() override {
@@ -30,7 +30,7 @@ class RenderMediaLogTest : public testing::Test {
}
void AddEvent(media::MediaLogEvent::Type type) {
- log_->AddEvent(log_->CreateEvent(type));
+ log_.AddEvent(log_.CreateEvent(type));
// AddEvent() could post. Run the task runner to make sure it's executed.
task_runner_->RunUntilIdle();
}
@@ -58,7 +58,7 @@ class RenderMediaLogTest : public testing::Test {
private:
base::MessageLoop message_loop_;
MockRenderThread render_thread_;
- scoped_refptr<RenderMediaLog> log_;
+ RenderMediaLog log_;
base::SimpleTestTickClock* tick_clock_; // Owned by |log_|.
scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
« no previous file with comments | « content/renderer/media/render_media_log.cc ('k') | content/renderer/media/webmediaplayer_ms.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698