Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: media/mojo/services/interface_factory_impl.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/interface_factory_impl.h ('k') | media/mojo/services/media_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/interface_factory_impl.cc
diff --git a/media/mojo/services/interface_factory_impl.cc b/media/mojo/services/interface_factory_impl.cc
index 143e5b6e2f0d695dd0717af56c450a1b99511c47..baac449991d95a452a83ca8ab74dfe4c2be99887 100644
--- a/media/mojo/services/interface_factory_impl.cc
+++ b/media/mojo/services/interface_factory_impl.cc
@@ -37,14 +37,16 @@ namespace media {
InterfaceFactoryImpl::InterfaceFactoryImpl(
service_manager::mojom::InterfaceProviderPtr interfaces,
- scoped_refptr<MediaLog> media_log,
+ MediaLog* media_log,
std::unique_ptr<service_manager::ServiceContextRef> connection_ref,
MojoMediaClient* mojo_media_client)
:
+#if defined(ENABLE_MOJO_RENDERER)
+ media_log_(media_log),
+#endif
#if defined(ENABLE_MOJO_CDM)
interfaces_(std::move(interfaces)),
#endif
- media_log_(media_log),
connection_ref_(std::move(connection_ref)),
mojo_media_client_(mojo_media_client) {
DVLOG(1) << __func__;
« no previous file with comments | « media/mojo/services/interface_factory_impl.h ('k') | media/mojo/services/media_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698