media/formats/webm/webm_tracks_parser.cc - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/webm/webm_tracks_parser.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/webm/webm_tracks_parser.cc

diff --git a/media/formats/webm/webm_tracks_parser.cc b/media/formats/webm/webm_tracks_parser.cc

index 66287663ad131c6c50394e8a33c7784fc241717a..afa56ec7c5e7a962a4fd62c83690383c6b8b0ac6 100644

--- a/media/formats/webm/webm_tracks_parser.cc

+++ b/media/formats/webm/webm_tracks_parser.cc

@@ -45,8 +45,7 @@ static base::TimeDelta PrecisionCappedDefaultDuration(

return base::TimeDelta::FromMicroseconds(mult);

}

-WebMTracksParser::WebMTracksParser(const scoped_refptr<MediaLog>& media_log,

- bool ignore_text_tracks)

+WebMTracksParser::WebMTracksParser(MediaLog* media_log, bool ignore_text_tracks)

: ignore_text_tracks_(ignore_text_tracks),

media_log_(media_log),

audio_client_(media_log),