Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: media/formats/mp4/dolby_vision.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp4/box_reader_unittest.cc ('k') | media/formats/mp4/dolby_vision.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/dolby_vision.h
diff --git a/media/formats/mp4/dolby_vision.h b/media/formats/mp4/dolby_vision.h
index f527975e3e609db69c26d4cd97d1164c5ec4ef3b..3a0561ae8264b389ace955dc1c34e29e9f2803c7 100644
--- a/media/formats/mp4/dolby_vision.h
+++ b/media/formats/mp4/dolby_vision.h
@@ -25,7 +25,7 @@ struct MEDIA_EXPORT DolbyVisionConfiguration : Box {
// context and therefore the box header is not expected to be present
// in |data|.
// Returns true if |data| was successfully parsed.
- bool Parse(const uint8_t* data, int data_size);
+ bool ParseForTesting(const uint8_t* data, int data_size);
uint8_t dv_version_major;
uint8_t dv_version_minor;
@@ -38,8 +38,7 @@ struct MEDIA_EXPORT DolbyVisionConfiguration : Box {
VideoCodecProfile codec_profile;
private:
- bool ParseInternal(BufferReader* reader,
- const scoped_refptr<MediaLog>& media_log);
+ bool ParseInternal(BufferReader* reader, MediaLog* media_log);
};
} // namespace mp4
« no previous file with comments | « media/formats/mp4/box_reader_unittest.cc ('k') | media/formats/mp4/dolby_vision.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698