media/filters/ffmpeg_audio_decoder.h - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_audio_decoder.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/ffmpeg_audio_decoder.h

diff --git a/media/filters/ffmpeg_audio_decoder.h b/media/filters/ffmpeg_audio_decoder.h

index 8ac9d70abf214b6f6cae9b5480681db0d4f7b986..b719d7838eaef4e8c3bf765b2c9089cc4b117ec6 100644

--- a/media/filters/ffmpeg_audio_decoder.h

+++ b/media/filters/ffmpeg_audio_decoder.h

@@ -34,7 +34,7 @@ class MEDIA_EXPORT FFmpegAudioDecoder : public AudioDecoder {

public:

FFmpegAudioDecoder(

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,

- const scoped_refptr<MediaLog>& media_log);

+ MediaLog* media_log);

~FFmpegAudioDecoder() override;

// AudioDecoder implementation.

@@ -115,7 +115,7 @@ class MEDIA_EXPORT FFmpegAudioDecoder : public AudioDecoder {

std::unique_ptr<AudioDiscardHelper> discard_helper_;

- scoped_refptr<MediaLog> media_log_;

+ MediaLog* media_log_;

scoped_refptr<AudioBufferMemoryPool> pool_;