chromecast/media/service/cast_mojo_media_client.h - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/service/cast_mojo_media_client.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/media/service/cast_mojo_media_client.h

diff --git a/chromecast/media/service/cast_mojo_media_client.h b/chromecast/media/service/cast_mojo_media_client.h

index bcf890fb92e76043bf3058cd3272d1f3d99119f3..521507b2aa50363eea584b5c6aae18316170cb31 100644

--- a/chromecast/media/service/cast_mojo_media_client.h

+++ b/chromecast/media/service/cast_mojo_media_client.h

@@ -32,7 +32,7 @@ class CastMojoMediaClient : public ::media::MojoMediaClient {

scoped_refptr<::media::AudioRendererSink> CreateAudioRendererSink(

const std::string& audio_device_id) override;

std::unique_ptr<::media::RendererFactory> CreateRendererFactory(

- const scoped_refptr<::media::MediaLog>& media_log) override;

+ ::media::MediaLog* media_log) override;

std::unique_ptr<::media::CdmFactory> CreateCdmFactory(

service_manager::mojom::InterfaceProvider* host_interfaces) override;