Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: media/blink/webmediaplayer_util.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_util.h ('k') | media/blink/webmediasource_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_util.cc
diff --git a/media/blink/webmediaplayer_util.cc b/media/blink/webmediaplayer_util.cc
index 4eabad220195880157de66b818cd56e6b69dec58..340f09b6698371e4c08b1ef4245f2e5085433e5e 100644
--- a/media/blink/webmediaplayer_util.cc
+++ b/media/blink/webmediaplayer_util.cc
@@ -110,7 +110,7 @@ std::string LoadTypeToString(blink::WebMediaPlayer::LoadType load_type) {
void ReportMetrics(blink::WebMediaPlayer::LoadType load_type,
const GURL& url,
const blink::WebSecurityOrigin& security_origin,
- scoped_refptr<MediaLog> media_log) {
+ MediaLog* media_log) {
DCHECK(media_log);
// Report URL scheme, such as http, https, file, blob etc.
@@ -137,7 +137,7 @@ void ReportMetrics(blink::WebMediaPlayer::LoadType load_type,
void ReportPipelineError(blink::WebMediaPlayer::LoadType load_type,
PipelineStatus error,
- scoped_refptr<MediaLog> media_log) {
+ MediaLog* media_log) {
DCHECK_NE(PIPELINE_OK, error);
// Report the origin from where the media player is created.
« no previous file with comments | « media/blink/webmediaplayer_util.h ('k') | media/blink/webmediasource_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698