Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: media/blink/webmediaplayer_params.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_params.h ('k') | media/blink/webmediaplayer_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_params.cc
diff --git a/media/blink/webmediaplayer_params.cc b/media/blink/webmediaplayer_params.cc
index ce635b6cc34c8ff937ba8dfd154afa2e3ba21e6b..3cd835f5dc536aa25393a484efbb118fabc4404c 100644
--- a/media/blink/webmediaplayer_params.cc
+++ b/media/blink/webmediaplayer_params.cc
@@ -7,14 +7,13 @@
#include "base/single_thread_task_runner.h"
#include "base/task_runner.h"
#include "media/base/audio_renderer_sink.h"
-#include "media/base/media_log.h"
namespace media {
WebMediaPlayerParams::WebMediaPlayerParams(
+ std::unique_ptr<MediaLog> media_log,
const DeferLoadCB& defer_load_cb,
const scoped_refptr<SwitchableAudioRendererSink>& audio_renderer_sink,
- const scoped_refptr<MediaLog>& media_log,
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
const scoped_refptr<base::TaskRunner>& worker_task_runner,
const scoped_refptr<base::SingleThreadTaskRunner>& compositor_task_runner,
@@ -30,7 +29,7 @@ WebMediaPlayerParams::WebMediaPlayerParams(
bool embedded_media_experience_enabled)
: defer_load_cb_(defer_load_cb),
audio_renderer_sink_(audio_renderer_sink),
- media_log_(media_log),
+ media_log_(std::move(media_log)),
media_task_runner_(media_task_runner),
worker_task_runner_(worker_task_runner),
compositor_task_runner_(compositor_task_runner),
« no previous file with comments | « media/blink/webmediaplayer_params.h ('k') | media/blink/webmediaplayer_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698