Convert MediaLog from being ref counted to owned by WebMediaPlayer.

media/formats/mp4/dolby_vision.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/mp4/dolby_vision.h"
 
 #include "base/logging.h"
 #include "media/base/video_codecs.h"
 #include "media/formats/mp4/box_definitions.h"
 #include "media/formats/mp4/box_reader.h"
@@ skipping 16 matching lines @@
 FourCC DolbyVisionConfiguration::BoxType() const {
   return FOURCC_DVCC;
 }
 
 bool DolbyVisionConfiguration::Parse(BoxReader* reader) {
   return ParseInternal(reader, reader->media_log());
 }
 
 bool DolbyVisionConfiguration::Parse(const uint8_t* data, int data_size) {
   BufferReader reader(data, data_size);
-  return ParseInternal(&reader, new MediaLog());
+  // TODO(wolenetz): Questionable MediaLog usage, http://crbug.com/712310

[chcunningham, 2017/04/18 23:29:12]

This one should be easy to fix. We have the media log in box_reader which we
should have access to as we're creating this box in box_definitions.cc

[DaleCurtis, 2017/04/18 23:55:45]

Looking closer I think this is only used by the unittest, so I've renamed the
method to ParseForTesting() and dropped the comment.

+  MediaLog media_log;
+  return ParseInternal(&reader, &media_log);
 }
 
-bool DolbyVisionConfiguration::ParseInternal(
-    BufferReader* reader,
-    const scoped_refptr<MediaLog>& media_log) {
+bool DolbyVisionConfiguration::ParseInternal(BufferReader* reader,
+                                             MediaLog* media_log) {
   uint16_t profile_track_indication = 0;
   RCHECK(reader->Read1(&dv_version_major) && reader->Read1(&dv_version_minor) &&
          reader->Read2(&profile_track_indication));
 
   dv_profile = profile_track_indication >> 9;
   dv_level = (profile_track_indication >> 3) & 0x3F;
   rpu_present_flag = (profile_track_indication >> 2) & 1;
   el_present_flag = (profile_track_indication >> 1) & 1;
   bl_present_flag = profile_track_indication & 1;
 
@@ skipping 21 matching lines @@
            << " has_bl:" << static_cast<int>(bl_present_flag)
            << " has_el:" << static_cast<int>(el_present_flag)
            << " has_rpu:" << static_cast<int>(rpu_present_flag)
            << " profile type:" << codec_profile;
 
   return true;
 }
 
 }  // namespace mp4
 }  // namespace media