Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: media/formats/mp4/box_definitions.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp4/box_definitions.h ('k') | media/formats/mp4/box_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/box_definitions.cc
diff --git a/media/formats/mp4/box_definitions.cc b/media/formats/mp4/box_definitions.cc
index c1c9934ccc415d2af348fcdcd07aa03492af3a76..329d74e62eaf5a24cd53bc054b4b6c5734d255d6 100644
--- a/media/formats/mp4/box_definitions.cc
+++ b/media/formats/mp4/box_definitions.cc
@@ -587,12 +587,13 @@ bool AVCDecoderConfigurationRecord::Parse(BoxReader* reader) {
bool AVCDecoderConfigurationRecord::Parse(const uint8_t* data, int data_size) {
BufferReader reader(data, data_size);
- return ParseInternal(&reader, new MediaLog());
+ // TODO(wolenetz): Questionable MediaLog usage, http://crbug.com/712310
+ MediaLog media_log;
+ return ParseInternal(&reader, &media_log);
}
-bool AVCDecoderConfigurationRecord::ParseInternal(
- BufferReader* reader,
- const scoped_refptr<MediaLog>& media_log) {
+bool AVCDecoderConfigurationRecord::ParseInternal(BufferReader* reader,
+ MediaLog* media_log) {
RCHECK(reader->Read1(&version) && version == 1 &&
reader->Read1(&profile_indication) &&
reader->Read1(&profile_compatibility) &&
« no previous file with comments | « media/formats/mp4/box_definitions.h ('k') | media/formats/mp4/box_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698