media/formats/mp4/aac.h - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/aac.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mp4/aac.h

diff --git a/media/formats/mp4/aac.h b/media/formats/mp4/aac.h

index ac694cd99bac40d40ad4db5860066831005f728a..b6244ab4a96277b1521095c6113d7c569bc36b0e 100644

--- a/media/formats/mp4/aac.h

+++ b/media/formats/mp4/aac.h

@@ -34,8 +34,7 @@ class MEDIA_EXPORT AAC {

// The function will parse the data and get the ElementaryStreamDescriptor,

// then it will parse the ElementaryStreamDescriptor to get audio stream

// configurations.

- bool Parse(const std::vector<uint8_t>& data,

- const scoped_refptr<MediaLog>& media_log);

+ bool Parse(const std::vector<uint8_t>& data, MediaLog* media_log);

// Gets the output sample rate for the AAC stream.

// |sbr_in_mimetype| should be set to true if the SBR mode is

« no previous file with comments | « media/formats/mp2t/mp2t_stream_parser_unittest.cc ('k') | media/formats/mp4/aac.cc » ('j') | no next file with comments »