Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink_gc_plugin: retire overloaded traceImpl detection and handling. With the specialized InlineGlobalMarkingVisitor gone (r445993), Blink no longer use a templated traceImpl() method for its trace methods. Follow up and remove the checks for it in the GC plugin. R= BUG=683019 Review-Url: https://codereview.chromium.org/2655933002 Cr-Commit-Position: refs/heads/master@{#446137} Committed: https://chromium.googlesource.com/chromium/src/+/03ae1414017283641bd3b22680c25ed18174b641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -866 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M tools/clang/blink_gc_plugin/CheckTraceVisitor.h View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/CheckTraceVisitor.cpp View 6 chunks +4 lines, -21 lines 0 comments Download
M tools/clang/blink_gc_plugin/Config.h View 5 chunks +2 lines, -18 lines 0 comments Download
M tools/clang/blink_gc_plugin/Config.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 3 chunks +1 line, -7 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/heap/stubs.h View 1 chunk +6 lines, -19 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/heap/stubs.h View 1 chunk +6 lines, -19 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h View 1 chunk +6 lines, -16 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl.h View 4 chunks +4 lines, -36 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl.cpp View 3 chunks +1 line, -34 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.h View 4 chunks +5 lines, -34 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp View 3 chunks +1 line, -34 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.txt View 1 chunk +18 lines, -18 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h View 3 chunks +2 lines, -17 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.h View 1 chunk +3 lines, -26 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h View 1 chunk +1 line, -6 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.h View 4 chunks +2 lines, -14 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h View 2 chunks +2 lines, -16 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_overloaded.h View 1 chunk +3 lines, -24 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_overloaded.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_overloaded_error.h View 3 chunks +2 lines, -25 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_overloaded_error.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_overloaded_error.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/register_weak_members_template.h View 1 chunk +7 lines, -17 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/register_weak_members_template.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.h View 4 chunks +4 lines, -34 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.cpp View 3 chunks +1 line, -34 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.h View 4 chunks +5 lines, -33 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.cpp View 3 chunks +1 line, -34 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.txt View 1 chunk +18 lines, -18 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl.h View 3 chunks +2 lines, -17 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.h View 1 chunk +3 lines, -26 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_derived_from_templated_base.h View 1 chunk +1 line, -6 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_error.h View 4 chunks +2 lines, -14 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_error.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h View 2 chunks +2 lines, -16 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_overloaded.h View 2 chunks +2 lines, -24 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_overloaded.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h View 1 chunk +4 lines, -25 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.txt View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look. locally verified Blink to build w/ a GC plugin based on ...
3 years, 11 months ago (2017-01-25 19:01:05 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-25 20:18:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655933002/1
3 years, 11 months ago (2017-01-25 21:52:16 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 22:07:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03ae1414017283641bd3b22680c2...

Powered by Google App Engine
This is Rietveld 408576698