Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.cpp

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.cpp b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.cpp
index 46553f3d9d08fc6a9d18372a3e052bf5e9c8bf98..76dc9761c69534fa215befae72f588298bc6b274 100644
--- a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.cpp
+++ b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.cpp
@@ -6,9 +6,7 @@
namespace blink {
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchInlinedBase::TraceImpl(
- VisitorDispatcher visitor) {
+inline void TraceAfterDispatchInlinedBase::Trace(Visitor* visitor) {
// Implement a simple form of manual dispatching, because BlinkGCPlugin
// checks if the tracing is dispatched to all derived classes.
//
@@ -24,15 +22,6 @@ inline void TraceAfterDispatchInlinedBase::TraceImpl(
}
void TraceAfterDispatchExternBase::Trace(Visitor* visitor) {
- TraceImpl(visitor);
-}
-
-void TraceAfterDispatchExternBase::Trace(InlinedGlobalMarkingVisitor visitor) {
- TraceImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternBase::TraceImpl(VisitorDispatcher visitor) {
if (tag_ == DERIVED) {
// Missing dispatch call:
// static_cast<TraceAfterDispatchExternDerived*>(this)->TraceAfterDispatch(
@@ -43,32 +32,10 @@ inline void TraceAfterDispatchExternBase::TraceImpl(VisitorDispatcher visitor) {
}
void TraceAfterDispatchExternBase::TraceAfterDispatch(Visitor* visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-void TraceAfterDispatchExternBase::TraceAfterDispatch(
- InlinedGlobalMarkingVisitor visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternBase::TraceAfterDispatchImpl(
- VisitorDispatcher visitor) {
// No Trace call.
}
void TraceAfterDispatchExternDerived::TraceAfterDispatch(Visitor* visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-void TraceAfterDispatchExternDerived::TraceAfterDispatch(
- InlinedGlobalMarkingVisitor visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternDerived::TraceAfterDispatchImpl(
- VisitorDispatcher visitor) {
// Ditto.
}

Powered by Google App Engine
This is Rietveld 408576698