Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h b/tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h
index 7a171be8065fa259b3d940b0fe2fa9de48bb2f73..6b359659ecd1813a30ffbdb0538ea8154b4b81dd 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.h
@@ -11,14 +11,7 @@ namespace blink {
class A : public GarbageCollected<A> {
public:
- virtual void Trace(Visitor* visitor) { TraceImpl(visitor); }
- virtual void Trace(InlinedGlobalMarkingVisitor visitor) {
- TraceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {}
+ virtual void Trace(Visitor* visitor) {}
};
class B : public A {
@@ -27,14 +20,7 @@ class B : public A {
class C : public B {
public:
- void Trace(Visitor* visitor) override { TraceImpl(visitor); }
- void Trace(InlinedGlobalMarkingVisitor visitor) override {
- TraceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {
+ void Trace(Visitor* visitor) override {
// B::Trace() is actually A::Trace(), and in certain cases we only get
// limited information like "there is a function call that will be resolved
// to A::Trace()". We still want to mark B as Traced.
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/traceimpl_error.txt ('k') | tools/clang/blink_gc_plugin/tests/traceimpl_overloaded.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698